Skip to content

Commit 4d584a3

Browse files
Merge pull request #605 from cloudinary/DEVX-17479-Allow-analytics-feature-flag-override
feat: DEVX-17479-Allow-analytics-feature-flag-override
2 parents f7c91d3 + 9ae1b82 commit 4d584a3

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

__TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const bundleSizeTestCases:ITestCase[] = [
2424
},
2525
{
2626
name: 'Tests CloudinaryImage with Resize and Adjust',
27-
sizeLimitInKB: 33,
27+
sizeLimitInKB: 34,
2828
importsArray: [
2929
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
3030
importFromDist('instance/Cloudinary', 'Cloudinary'),
@@ -34,7 +34,7 @@ const bundleSizeTestCases:ITestCase[] = [
3434
},
3535
{
3636
name: 'Tests CloudinaryImage with Resize, Adjust and Border',
37-
sizeLimitInKB: 34,
37+
sizeLimitInKB: 35,
3838
importsArray: [
3939
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
4040
importFromDist('instance/Cloudinary', 'Cloudinary'),
@@ -45,7 +45,7 @@ const bundleSizeTestCases:ITestCase[] = [
4545
},
4646
{
4747
name: 'Tests CloudinaryImage image with Resize, adjust and delivery',
48-
sizeLimitInKB: 35,
48+
sizeLimitInKB: 36,
4949
importsArray: [
5050
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
5151
importFromDist('instance/Cloudinary', 'Cloudinary'),
@@ -74,7 +74,7 @@ const bundleSizeTestCases:ITestCase[] = [
7474
},
7575
{
7676
name: 'Import all of the SDK',
77-
sizeLimitInKB: 140,
77+
sizeLimitInKB: 142,
7878
importsArray: [
7979
importFromPackage('* as CloudinaryURLGEN')
8080
]
@@ -88,7 +88,7 @@ const bundleSizeTestCases:ITestCase[] = [
8888
},
8989
{
9090
name: 'Import All Actions',
91-
sizeLimitInKB: 65,
91+
sizeLimitInKB: 67,
9292
importsArray: [
9393
importFromPackage('Actions')
9494
]

src/sdkAnalytics/getAnalyticsOptions.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,9 @@ export function getAnalyticsOptions(options: ITrackedPropertiesThroughAnalytics)
3434
analyticsOptions.feature = 'B';
3535
}
3636

37+
if (options.feature) {
38+
analyticsOptions.feature = options.feature;
39+
}
40+
3741
return analyticsOptions;
3842
}

src/sdkAnalytics/interfaces/ITrackedPropertiesThroughAnalytics.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,6 @@ export interface ITrackedPropertiesThroughAnalytics {
1515
lazyload?: boolean; // Was lazy-load used
1616
responsive?: boolean; // Was responsive used
1717
placeholder?: boolean; // Was placeholder used
18+
feature?: string;
1819
}
1920

0 commit comments

Comments
 (0)