Merge pull request #72 from cloudnc/fix/demo-app-compilation

chore: fix demo app compilation and make sure to build it on CI to not break it again

Author: maxime1992

.github/workflows/main.yml

@@ -26,8 +26,10 @@ jobs:
         run: yarn prettier:check
       - name: Check Readme
         run: yarn readme:check
-      - name: Build
+      - name: Build lib
         run: yarn lib:build:prod
+      - name: Build app
+        run: yarn demo:build:prod
       - name: Test
         run: yarn lib:test:ci
       - name: Coverage

README.md

@@ -40,7 +40,7 @@ import { getObservableLifecycle } from 'ngx-observable-lifecycle';
 import { Observable } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
-export function automaticUnsubscribe<T>(component): (source: Observable<T>) => Observable<T> {
+export function automaticUnsubscribe<T>(component: any): (source: Observable<T>) => Observable<T> {
   const { ngOnDestroy } = getObservableLifecycle(component);
   return (source: Observable<T>): Observable<T> => source.pipe(takeUntil(ngOnDestroy));
 }

src/app/app.component.html

@@ -1,4 +1,4 @@
-<app-child *ngIf="showChildComponent" [input]="inputValue"></app-child>
+<app-child *ngIf="showChildComponent" [input1]="inputValue"></app-child>
 <hr />
 <button (click)="inputValue = inputValue + 1">Increment inputValue</button>
 <button (click)="showChildComponent = !showChildComponent">Toggle child component</button>

src/app/child/child.component.html

@@ -1,2 +1,2 @@
 <p>child-component works!</p>
-input value is: {{ input }}
+input value is: {{ input1 }}

src/app/lib-example/lib-example.ts

@@ -2,7 +2,7 @@ import { getObservableLifecycle } from 'ngx-observable-lifecycle';
 import { Observable } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
-export function automaticUnsubscribe<T>(component): (source: Observable<T>) => Observable<T> {
+export function automaticUnsubscribe<T>(component: any): (source: Observable<T>) => Observable<T> {
   const { ngOnDestroy } = getObservableLifecycle(component);
   return (source: Observable<T>): Observable<T> => source.pipe(takeUntil(ngOnDestroy));
 }