Schema: `depends_on_manifest` missing `stack` property

[osterman]

Bug

The depends_on_manifest definition in the JSON schema is missing the stack property. Since the schema sets "additionalProperties": false, IDEs that reference the schema flag stack as invalid.

Expected

The stack key should be accepted in depends_on entries, as it is:

• Documented: https://atmos.tools/stacks/settings/depends_on lists stack as an optional key with examples
• Supported at runtime: The Go struct Dependent in pkg/schema/schema.go has a Stack field
• Used in practice: Users specify stack to reference components in different Atmos stacks

Actual

All 3 copies of the schema are missing stack in depends_on_manifest properties:

1. pkg/datafetcher/schema/atmos/manifest/1.0.json
2. pkg/datafetcher/schema/stacks/stack-config/1.0.json
3. website/static/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json (published to https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json)

Fix

Add "stack": { "type": "string" } to the depends_on_manifest properties in all 3 files.

Related

The schema also only recognizes !include via regex pattern. Other YAML function tags (!terraform.state, !terraform.output, !exec, !store, etc.) are not represented, causing IDE false positives. This is a separate, broader issue.

Reported by

Brogan Klombies via contact form

Cloud Posse, LLC Mail - Brogan Klombies - Engineering Consultation Request.pdf

[BroganRenoworks]

Thanks for opening this Erik!