Canonicalize OpenSearch IAM policy using sort() to prevent Terraform drift#221
Open
asri-badlah wants to merge 7 commits intocloudposse:mainfrom
Open
Canonicalize OpenSearch IAM policy using sort() to prevent Terraform drift#221asri-badlah wants to merge 7 commits intocloudposse:mainfrom
asri-badlah wants to merge 7 commits intocloudposse:mainfrom
Conversation
* Update go.sum * Auto Format * Update go.sum * Update go.sum * Update go.sum * Fix versions --------- Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com> (cherry picked from commit c6e9dfe)
* Added AutoTune support * Auto Format * Update variables.tf Co-authored-by: Igor Rodionov <goruha@gmail.com> * Update variables.tf Co-authored-by: Igor Rodionov <goruha@gmail.com> * Update variables.tf Co-authored-by: Igor Rodionov <goruha@gmail.com> * Auto Format * Rework auto_tune variables to single object * Try to fix variables.tf lint * Auto Format * Update variables.tf Co-authored-by: Igor Rodionov <goruha@gmail.com> * Update variables.tf Co-authored-by: Igor Rodionov <goruha@gmail.com> --------- Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com> Co-authored-by: Igor Rodionov <goruha@gmail.com> (cherry picked from commit 7f83b65)
* Support ebs_throughput to enable using of gp3 * Auto Format --------- Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com> (cherry picked from commit dcd0c48)
|
💥 This pull request now has conflicts. Could you fix it @asri-badlah? 🙏 |
matteomallus
force-pushed
the
canonicalize-openSearch-IAM-policy
branch
from
22055e1 to
3036720
Compare
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
This PR updates the
data.aws_iam_policy_document.defaultblock in the OpenSearch module to ensure consistent ordering of principals and resources when generating the policy JSON.why
Terraform was detecting in-place updates for
aws_opensearch_domain_policydue to differences in array ordering between what AWS returns and what Terraform generates. This drift is harmless but causes unnecessary terraform plan changes and confusion.This issue is especially apparent after upgrading Terraform or the AWS provider, as newer versions perform a strict literal comparison of JSON arrays.