Skip to content

Commit 1b7aed0

Browse files
committed
[FIX] fix variant_array implementation
1 parent 742b3a0 commit 1b7aed0

File tree

3 files changed

+230
-86
lines changed

3 files changed

+230
-86
lines changed

parquet-variant-compute/examples/field_removal.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,4 @@ fn main() {
107107
}
108108
}
109109

110-
println!("\n=== Performance Features ===");
111-
println!("✓ Efficient field removal at byte level");
112-
println!("✓ Support for nested field removal");
113-
println!("✓ Batch operations for cleaning multiple fields");
114-
println!("✓ Maintains data integrity during field removal");
115-
println!("✓ Foundation for data governance and privacy compliance");
116110
}

parquet-variant-compute/src/from_json.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ pub fn batch_json_string_to_variant(input: &ArrayRef) -> Result<VariantArray, Ar
5454
#[cfg(test)]
5555
mod test {
5656
use crate::batch_json_string_to_variant;
57-
use arrow::array::{Array, ArrayRef, StringArray};
57+
use arrow::array::{Array, ArrayRef, AsArray, StringArray};
5858
use arrow_schema::ArrowError;
5959
use std::sync::Arc;
6060

@@ -103,10 +103,10 @@ mod test {
103103
assert!(!value_array.is_null(4));
104104

105105
// Null rows should have 0-length metadata and value
106-
assert_eq!(metadata_array.value(1).len(), 0);
107-
assert_eq!(value_array.value(1).len(), 0);
108-
assert_eq!(metadata_array.value(4).len(), 0);
109-
assert_eq!(value_array.value(4).len(), 0);
106+
assert_eq!(metadata_array.as_binary_view().value(1).len(), 0);
107+
assert_eq!(value_array.as_binary_view().value(1).len(), 0);
108+
assert_eq!(metadata_array.as_binary_view().value(4).len(), 0);
109+
assert_eq!(value_array.as_binary_view().value(4).len(), 0);
110110
Ok(())
111111
}
112112
}

0 commit comments

Comments
 (0)