Skip to content

Commit c2df8f3

Browse files
committed
refactor(server,ci): remove unused variables
1 parent 70841ce commit c2df8f3

File tree

4 files changed

+0
-13
lines changed

4 files changed

+0
-13
lines changed

.github/workflows/docker-build.ecr.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,23 +58,19 @@ jobs:
5858
if [[ "${{ github.ref_type }}" == "tag" ]]; then
5959
# Tag deployment - display version, link to release
6060
echo "version=${{ github.ref_name }}" >> $GITHUB_OUTPUT
61-
echo "deployment_type=tag" >> $GITHUB_OUTPUT
6261
echo "app_version=${{ github.ref_name }}" >> $GITHUB_OUTPUT
6362
echo "app_version_url=${REPO_URL}/releases/tag/${{ github.ref_name }}" >> $GITHUB_OUTPUT
6463
elif [[ "${{ github.event_name }}" == "pull_request" ]]; then
6564
# PR deployment - display pr-XXX, link to PR commit
6665
PR_NUMBER="${{ github.event.pull_request.number }}"
6766
COMMIT_HASH="${{ steps.vars.outputs.sha_full }}"
6867
echo "version=${PR_NUMBER}/merge-${COMMIT_HASH}" >> $GITHUB_OUTPUT
69-
echo "deployment_type=pr" >> $GITHUB_OUTPUT
7068
echo "app_version=pr-${PR_NUMBER}" >> $GITHUB_OUTPUT
7169
echo "app_version_url=${REPO_URL}/pull/${PR_NUMBER}/commits/${COMMIT_HASH}" >> $GITHUB_OUTPUT
7270
else
7371
# Branch deployment - display branch name, link to commit
7472
BRANCH_NAME="${{ github.ref_name }}"
7573
COMMIT_HASH="${{ steps.vars.outputs.sha_full }}"
76-
echo "version=${BRANCH_NAME}-${COMMIT_HASH}" >> $GITHUB_OUTPUT
77-
echo "deployment_type=branch" >> $GITHUB_OUTPUT
7874
echo "app_version=${BRANCH_NAME}" >> $GITHUB_OUTPUT
7975
echo "app_version_url=${REPO_URL}/commit/${COMMIT_HASH}" >> $GITHUB_OUTPUT
8076
fi
@@ -111,7 +107,6 @@ jobs:
111107
tags: ${{ steps.meta.outputs.tags }}
112108
labels: ${{ steps.meta.outputs.labels }}
113109
build-args: |
114-
VERSION=${{ steps.version.outputs.version }}
115110
APP_REPOSITORY=https://github.com/${{ github.repository }}
116111
APP_VERSION=${{ steps.version.outputs.app_version }}
117112
APP_VERSION_URL=${{ steps.version.outputs.app_version_url }}

.github/workflows/docker-build.ghcr.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,23 +62,19 @@ jobs:
6262
if [[ "${{ github.ref_type }}" == "tag" ]]; then
6363
# Tag deployment - display version, link to release
6464
echo "version=${{ github.ref_name }}" >> $GITHUB_OUTPUT
65-
echo "deployment_type=tag" >> $GITHUB_OUTPUT
6665
echo "app_version=${{ github.ref_name }}" >> $GITHUB_OUTPUT
6766
echo "app_version_url=${REPO_URL}/releases/tag/${{ github.ref_name }}" >> $GITHUB_OUTPUT
6867
elif [[ "${{ github.event_name }}" == "pull_request" ]]; then
6968
# PR deployment - display pr-XXX, link to PR commit
7069
PR_NUMBER="${{ github.event.pull_request.number }}"
7170
COMMIT_HASH="${{ steps.vars.outputs.sha_full }}"
7271
echo "version=${PR_NUMBER}/merge-${COMMIT_HASH}" >> $GITHUB_OUTPUT
73-
echo "deployment_type=pr" >> $GITHUB_OUTPUT
7472
echo "app_version=pr-${PR_NUMBER}" >> $GITHUB_OUTPUT
7573
echo "app_version_url=${REPO_URL}/pull/${PR_NUMBER}/commits/${COMMIT_HASH}" >> $GITHUB_OUTPUT
7674
else
7775
# Branch deployment - display branch name, link to commit
7876
BRANCH_NAME="${{ github.ref_name }}"
7977
COMMIT_HASH="${{ steps.vars.outputs.sha_full }}"
80-
echo "version=${BRANCH_NAME}-${COMMIT_HASH}" >> $GITHUB_OUTPUT
81-
echo "deployment_type=branch" >> $GITHUB_OUTPUT
8278
echo "app_version=${BRANCH_NAME}" >> $GITHUB_OUTPUT
8379
echo "app_version_url=${REPO_URL}/commit/${COMMIT_HASH}" >> $GITHUB_OUTPUT
8480
fi
@@ -120,7 +116,6 @@ jobs:
120116
tags: ${{ steps.meta.outputs.tags }}
121117
labels: ${{ steps.meta.outputs.labels }}
122118
build-args: |
123-
VERSION=${{ steps.version.outputs.version }}
124119
APP_REPOSITORY=https://github.com/${{ github.repository }}
125120
APP_VERSION=${{ steps.version.outputs.app_version }}
126121
APP_VERSION_URL=${{ steps.version.outputs.app_version_url }}

Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,12 @@ FROM python:3.13.5-slim@sha256:4c2cf9917bd1cbacc5e9b07320025bdb7cdf2df7b0ceaccb5
2020

2121
ARG UID=1000
2222
ARG GID=1000
23-
ARG VERSION=unknown
2423
ARG APP_REPOSITORY=https://github.com/coderamp-labs/gitingest
2524
ARG APP_VERSION=unknown
2625
ARG APP_VERSION_URL=https://github.com/coderamp-labs/gitingest
2726

2827
ENV PYTHONUNBUFFERED=1 \
2928
PYTHONDONTWRITEBYTECODE=1 \
30-
VERSION=${VERSION} \
3129
APP_REPOSITORY=${APP_REPOSITORY} \
3230
APP_VERSION=${APP_VERSION} \
3331
APP_VERSION_URL=${APP_VERSION_URL}

src/server/server_config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323

2424

2525
# Version and repository configuration
26-
VERSION = os.getenv("VERSION", "unknown")
2726
APP_REPOSITORY = os.getenv("APP_REPOSITORY", "https://github.com/coderamp-labs/gitingest")
2827
APP_VERSION = os.getenv("APP_VERSION", "unknown")
2928
APP_VERSION_URL = os.getenv("APP_VERSION_URL", "https://github.com/coderamp-labs/gitingest")

0 commit comments

Comments
 (0)