Honda: Merge Kinematics #2797
Merged
Honda: Merge Kinematics #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the bosch kinematics has just been wrong since it was added. will put the other signal cleanups in my other PR. |
leonunix
pushed a commit
to leonunix/opendbc-origin
that referenced
this pull request
Sep 29, 2025
* 'master' of github.com:leonunix/opendbc: (524 commits) safety: remove board/ folder (commaai#2814) safety: namespace helpers (commaai#2813) always build libsafety for mutation tests (commaai#2811) build system cleanups (commaai#2810) move mull install to setup.sh utils == helpers (commaai#2809) consolidate libsafety files (commaai#2808) safety: cleanup remaining panda bits (commaai#2807) docs: Scheduled auto-update CARS.md Honda: Acura TLX 2021 support (commaai#2717) HKG: Add FW for 2017 Hyundai Ioniq Hybrid (commaai#2784) Honda - Update extra cars (commaai#2801) Add new fingerprints for Tesla Model X (commaai#2710) docs: Scheduled auto-update CARS.md Revert "Capnp memoryview (commaai#2793)" Capnp memoryview (commaai#2793) Honda: 2026 Honda Passport (commaai#2657) Honda: Merge Kinematics (commaai#2797) HKG: Add FW for 2023 Hyundai Elantra (commaai#2796) HKG: Add FW for 2024 Genesis GV70 (commaai#2787) ... # Conflicts: # docs/CARS.md # opendbc/car/honda/carstate.py # opendbc/car/honda/interface.py # opendbc/car/honda/values.py # opendbc/car/tests/routes.py # opendbc/car/torque_data/substitute.toml # opendbc/safety/modes/honda.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging as discussed in #2794
Will make this a simple merge PR, and add other signals and fixes in the other PR.
Bosch Kinematics seems to have a bit different signal scaling and offset than nidec. Leaving as draft for the moment to verify.