Skip to content

Commit dbcba9f

Browse files
committed
cleanup
1 parent ec47373 commit dbcba9f

File tree

5 files changed

+19
-42
lines changed

5 files changed

+19
-42
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,7 @@ pip install ipython2cwl
3939
```
4040
jupyter repo2cwl https://github.com/giannisdoukas/cwl-annotated-jupyter-notebook.git -o cwlbuild
4141
```
42+
43+
### Docs
44+
45+
[https://ipython2cwl.readthedocs.io/](https://readthedocs.org/projects/ipython2cwl/badge/?version=latest)

ipython2cwl/ipython2cwl.py

Lines changed: 0 additions & 39 deletions
This file was deleted.

ipython2cwl/repo2cwl.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def _store_jn_as_script(notebook_path: str, git_directory_absolute_path: str, bi
7272
def existing_path(path: str):
7373
path = Path(path)
7474
if not path.is_dir():
75-
raise ValueError('Directory does not exists')
75+
raise argparse.ArgumentTypeError(f'Directory: {str(path)} does not exists')
7676
return path
7777

7878

setup.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,20 @@ def get_version(rel_path):
4242
"License :: OSI Approved :: Apache Software License",
4343
"Operating System :: MacOS",
4444
"Operating System :: POSIX",
45-
"Development Status :: 2 - Pre-Alpha",
45+
"Development Status :: 3 - Alpha",
4646
"Framework :: IPython",
4747
"Programming Language :: Python :: 3.6",
4848
"Programming Language :: Python :: 3.7",
4949
"Programming Language :: Python :: 3.8",
50+
'Topic :: Scientific/Engineering',
51+
'Topic :: Scientific/Engineering :: Astronomy',
52+
'Topic :: Scientific/Engineering :: Atmospheric Science',
53+
'Topic :: Scientific/Engineering :: Bio-Informatics',
54+
'Topic :: Scientific/Engineering :: Information Analysis',
55+
'Topic :: Scientific/Engineering :: Medical Science Apps.'
5056
],
5157
entry_points={
5258
'console_scripts': [
53-
# 'jupyter-jn2cwl=ipython2cwl.ipython2cwl:main',
5459
'jupyter-repo2cwl=ipython2cwl.repo2cwl:repo2cwl',
5560
],
5661
},

tests/test_system_tests.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import os
22
import shutil
33
import tempfile
4+
import uuid
45
from subprocess import DEVNULL
56
from unittest import TestCase, skipIf
67

@@ -47,3 +48,9 @@ def test_repo2cwl(self):
4748
new_data = yaml.safe_load(f)
4849
self.assertDictEqual({'entry1': 2, 'entry2': 'foo', 'entry3': 'bar'}, new_data)
4950
shutil.rmtree(output_dir)
51+
52+
def test_repo2cwl_output_dir_does_not_exists(self):
53+
random_dir_name = str(uuid.uuid4())
54+
repo2cwl = pkg_resources.load_entry_point('ipython2cwl', 'console_scripts', 'jupyter-repo2cwl')
55+
with self.assertRaises(SystemExit):
56+
repo2cwl(['-o', random_dir_name, self.repo_like_dir])

0 commit comments

Comments
 (0)