Skip to content

Commit 6eccf93

Browse files
committed
ci: Fix release upload by passing tag and refining permissions/files
Ensure the CD workflow passes the release tag explicitly to `softprops/action-gh-release` using `tag_name` fixing the error "GitHub Releases requires a tag". Also: - Define minimal job-level permissions (`contents: write`) - Refine glob pattern to upload only from `*-packages/` - Restrict file listing in the debug step to avoid noise
1 parent 90faead commit 6eccf93

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

.github/workflows/CD.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,15 @@ on:
1010
types:
1111
- published
1212

13+
permissions: {} # No permissions are granted at the workflow level
14+
1315
jobs:
1416
upload-release-assets:
1517
runs-on: ubuntu-latest
1618

19+
permissions:
20+
contents: write
21+
1722
steps:
1823
- name: Set TAG_NAME
1924
id: vars
@@ -48,12 +53,13 @@ jobs:
4853
name_is_regexp: true
4954

5055
- name: List downloaded files
51-
run: ls -1 -R
56+
run: ls -1 -R *-packages
5257

5358
- name: Upload release assets
5459
uses: softprops/action-gh-release@v1
5560
with:
61+
tag_name: ${{ steps.vars.outputs.TAG_NAME }}
5662
files: |
57-
**/CTKAppLauncher-*.tar.gz
63+
*-packages/CTKAppLauncher-*.tar.gz
5864
env:
5965
GITHUB_TOKEN: ${{ secrets.COMMONTKBOT_GITHUB_TOKEN }}

0 commit comments

Comments
 (0)