Calibre-Web-Automated

[vhsdream]

community-scripts/ProxmoxVE#125

Application Name
Calibre-Web-Automated

Website
https://github.com/crocodilestick/Calibre-Web-Automated

Description
I'm a big fan of the scripts. I know that the Calibre Web Script already exists, but the programme I am proposing is more than just an extension. The range of functions is many times greater and therefore my question is whether this would be more of an ‘extra’ script or whether there could be a selection in the installation process / deployment which of the two existing scripts should be installed?

[vhsdream]

I'd like to get a discussion going around this one. Namely about whether a conversion from Calibre-Web to Calibre-Web Automated should be one of the options in the Calibre-Web update script, or whether standalone is the way to go.

Besides that, although I have figured out how to do the conversion/install from scratch, it so far has required modifying a lot of files in the Calibre-Web Automated repo. This has been done by creating a patch file that is applied during the conversion.

I would like to hear ideas of how a more stable and secure method of patching the files could be achieved, and also (depending on if we go the standalone or add-on route) how we would handle updates since there are really two things that need updating.

I will share the WIP standalone script later on today.

[MickLesk]

wget -q https://gist.githubusercontent.com/vhsdream/2e81afeff139c5746db1ede88c01cc7b/raw/51238206e87aec6c0abeccce85dec9f2b0c89000/proxmox-lxc.patch -O /opt/cwa.patch # not for production

whats that?

[vhsdream]

wget -q https://gist.githubusercontent.com/vhsdream/2e81afeff139c5746db1ede88c01cc7b/raw/51238206e87aec6c0abeccce85dec9f2b0c89000/proxmox-lxc.patch -O /opt/cwa.patch # not for production

whats that?

That's the patch file that I mentioned above. For Calibre-Web Automated LXC to work, I had to modify file paths in a number of different files, as well as create two scripts (although the scripts are based on existing ones in the CWA repo).

I have the 'not for production' comment to remind me (and us) that before releasing this script we'll have to come up with a better way of modifying the files, without having the install and update script becoming too unwieldy.

I'm thinking it can be done with sed scripting withiin the bash scripts, which solves the 'grabbing a random patch file hosted elsewhere' problem. But there is still the issue of staying on top of CWA updates - if filenames/paths change we'll have to be aware of that and will need to adjust the sed script as needed.

[vhsdream]

Update:

I've found a way to patch CWA for installation in a Proxmox LXC without using a patch file; but I don't know if y'all are gonna like it.

Been working on and testing using a new func script (calling it cwa_patcher.func) to do all the heavy lifting of modfying all the necessary files (using a ridiculous amount of sed commands) as well as generating a few scripts that compose the bulk of the 'Automated' part of Calibre-Web Automated.

But obviously this means there would be another func script, in the misc folder, which I understand is a big change, so I haven't pushed anything to the repo yet, even though it is at least ready to be tested and torn apart by smarter folks.

@MickLesk - my dev fork is here if you want to take a look at the changes.

Perhaps instead of pushing it to Main here, we could make a branch and I could push to that.

[vhsdream]

I've pushed the proposed changes to the new cwa-func branch.

Likely I'm missing things, like how to handle and log/report errors caused by the function breaking or something like that, which may require the other functions to be updated? Not sure.