Add tests for PackageController::transferPackageAction()

Author: stevenrombauts

src/Controller/PackageController.php

@@ -1002,10 +1002,9 @@ public function transferPackageAction(Request $req, #[MapEntity] Package $packag
 
         if ($form->isSubmitted() && $form->isValid()) {
             try {
-                $em = $this->getEM();
                 $newMaintainers = $form->getData()->getMaintainers()->toArray();
                 $result = $this->packageManager->transferPackage($package, $oldMaintainers, $newMaintainers);
-                $em->flush();
+                $this->getEM()->flush();
 
                 if ($result) {
                     $usernames = array_map(fn (User $user) => $user->getUsername(), $newMaintainers);
@@ -1671,7 +1670,7 @@ private function createRemoveMaintainerForm(Package $package): FormInterface
     private function createTransferPackageForm(Package $package): FormInterface
     {
         $transferRequest = new TransferPackageRequest();
-        $transferRequest->setMaintainers($package->getMaintainers());
+        $transferRequest->setMaintainers(clone $package->getMaintainers());
 
         return $this->createForm(TransferPackageRequestType::class, $transferRequest);
     }

tests/Controller/PackageControllerTest.php

@@ -16,6 +16,7 @@
 use App\Entity\Package;
 use App\Entity\User;
 use App\Tests\IntegrationTestCase;
+use PHPUnit\Framework\Attributes\TestWith;
 
 class PackageControllerTest extends IntegrationTestCase
 {
@@ -144,4 +145,82 @@ public function testRemoveMaintainer(): void
 
         $this->assertNotNull($auditRecord);
     }
+
+    public function testTransferPackage(): void
+    {
+        $john = self::createUser('john', '[email protected]');
+        $alice = self::createUser('alice', '[email protected]');
+        $bob = self::createUser('bob', '[email protected]');
+        $package = self::createPackage('test/pkg', 'https://example.com/test/pkg', maintainers: [$john, $alice]);
+
+        $this->store($john, $alice, $bob, $package);
+
+        $this->client->loginUser($john);
+
+        $this->assertTrue($package->isMaintainer($john));
+        $this->assertTrue($package->isMaintainer($alice));
+        $this->assertFalse($package->isMaintainer($bob));
+
+        $crawler = $this->client->request('GET', '/packages/test/pkg');
+
+        $form = $crawler->filter('[name="transfer_package_form"]')->form();
+        $form->setValues([
+            'transfer_package_form[maintainers][0]' => 'alice',
+            'transfer_package_form[maintainers][1]' => '[email protected]',
+        ]);
+
+        $this->client->submit($form);
+
+        $this->assertResponseRedirects('/packages/test/pkg');
+        $this->client->followRedirect();
+        $this->assertResponseIsSuccessful();
+
+        $em = self::getEM();
+        $em->clear();
+
+        $package = $em->getRepository(Package::class)->find($package->getId());
+        $this->assertNotNull($package);
+
+        $maintainerIds = array_map(fn (User $user) => $user->getId(), $package->getMaintainers()->toArray());
+        $this->assertContains($alice->getId(), $maintainerIds);
+        $this->assertContains($bob->getId(), $maintainerIds);
+        $this->assertNotContains($john->getId(), $maintainerIds);
+
+        $auditRecord = $em->getRepository(\App\Entity\AuditRecord::class)->findOneBy([
+            'type' => AuditRecordType::PackageTransferred->value,
+            'packageId' => $package->getId(),
+        ]);
+
+        $this->assertNotNull($auditRecord, 'Audit record not found');
+    }
+
+    #[TestWith(['does_not_exist', 'value is not a valid username or email'])]
+    #[TestWith([null, 'at least one maintainer must be specified'])]
+    public function testTransferPackageReturnsValidationError(?string $value, string $message): void
+    {
+        $alice = self::createUser('alice', '[email protected]');
+        $package = self::createPackage('test/pkg', 'https://example.com/test/pkg', maintainers: [$alice]);
+
+        $this->store($alice, $package);
+
+        $this->client->loginUser($alice);
+
+        $crawler = $this->client->request('GET', '/packages/test/pkg');
+
+        $form = $crawler->filter('[name="transfer_package_form"]')->form();
+        $form->setValues([
+            'transfer_package_form[maintainers][0]' => $value,
+        ]);
+
+        $this->client->submit($form);
+
+        $this->assertResponseRedirects('/packages/test/pkg');
+        $crawler = $this->client->followRedirect();
+        $this->assertResponseIsSuccessful();
+
+        $elements = $crawler->filter('.flash-container .alert-error');
+        $this->assertCount(1, $elements);
+        $text = $elements->text();
+        $this->assertStringContainsStringIgnoringCase($message, $text);
+    }
 }