consolidate actions into pr and have one set with old vars still (#211)

Author: chrishagglund-ship-it

.github/workflows/backward-compatibility.yml

@@ -0,0 +1,60 @@
+name: Integration + Backward Compatibility Tests (Old Vars)
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+  workflow_dispatch:
+
+jobs:
+  integration-tests-oldvars:
+    runs-on: ubuntu-latest
+
+    env:
+      CONDUCTOR_SERVER_URL: ${{ secrets.CONDUCTOR_SERVER_URL }}
+      CONDUCTOR_AUTH_KEY: ${{ secrets.KEY }}
+      CONDUCTOR_AUTH_SECRET: ${{ secrets.SECRET }}
+
+    permissions:
+      contents: read       # minimal read access
+      checks: write        # needed for test report annotations
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: '1.23'
+
+      - name: Install dependencies
+        run: go mod download
+
+      - name: Build
+        run: go build ./...
+
+      - name: Install gotestsum
+        run: go install gotest.tools/gotestsum@v1.12.0
+
+      - name: Run Integration tests (Old Vars)
+        run: |
+          gotestsum --format testname  --junitfile report.xml -- -v ./test/integration_tests/...
+
+      - name: Publish test results (Old Vars)
+        if: always()
+        uses: dorny/test-reporter@v1
+        with:
+          name: Integration tests report (Old Vars)
+          path: report.xml
+          reporter: java-junit
+
+      - name: Run Backward Compatibility Tests (Old Vars)
+        run: |
+          echo "🚀 Starting Backward Compatibility Tests..."
+          cd test/backward_compatibility
+          chmod +x run_compatibility.sh
+          ./run_compatibility.sh

.github/workflows/integration-tests-oldvars.yml

@@ -1,27 +1,29 @@
-name: Integration Tests
+name: Integration + Backward Compatibility Tests
 
 on:
-  workflow_run:
-    workflows: ["Build"]
-    types:
-      - completed
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
   workflow_dispatch:
 
 jobs:
   integration-tests:
     runs-on: ubuntu-latest
-    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     env:
       CONDUCTOR_SERVER_URL: ${{ vars.SERVER_URL }}
       CONDUCTOR_AUTH_KEY: ${{ secrets.AUTH_KEY }}
       CONDUCTOR_AUTH_SECRET: ${{ secrets.AUTH_SECRET }}
-      
+
+    permissions:
+      contents: read       # minimal read access
+      checks: write        # needed for test report annotations
+
     steps:
       - name: Checkout
         uses: actions/checkout@v3
-        with:
-          ref: ${{ github.event.workflow_run.head_sha }}
-          repository: ${{ github.event.workflow_run.repository.full_name }}
 
       - name: Set up Go
         uses: actions/setup-go@v3
@@ -41,49 +43,17 @@ jobs:
         run: |
           gotestsum --format testname  --junitfile report.xml -- -v ./test/integration_tests/...
 
-      - name: Run Backward Compatibility Tests
-        run: |
-          echo "🚀 Starting Backward Compatibility Tests..."
-          cd test/backward_compatibility
-          chmod +x run_compatibility.sh
-          ./run_compatibility.sh
-
-      - name: Set PR Status to Failure
-        if: ${{ failure() }}
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const { owner, repo } = context.repo;
-            const sha = context.payload.workflow_run.head_sha;
-            await github.rest.repos.createCommitStatus({
-              owner: owner,
-              repo: repo,
-              sha: sha,
-              state: 'failure',
-              context: 'Integration Tests',
-              description: 'Integration tests failed.',
-            });
-
-      - name: Set PR Status to Success
-        if: ${{ success() }}
-        uses: actions/github-script@v6
-        with:
-          script: |
-            const { owner, repo } = context.repo;
-            const sha = context.payload.workflow_run.head_sha;
-            await github.rest.repos.createCommitStatus({
-              owner: owner,
-              repo: repo,
-              sha: sha,
-              state: 'success',
-              context: 'Integration Tests',
-              description: 'Integration tests succeeded.',
-            });
-
       - name: Publish test results
-        if: always() 
+        if: always()
         uses: dorny/test-reporter@v1
         with:
           name: Integration tests report
           path: report.xml
           reporter: java-junit
+
+      - name: Run Backward Compatibility Tests
+        run: |
+          echo "🚀 Starting Backward Compatibility Tests..."
+          cd test/backward_compatibility
+          chmod +x run_compatibility.sh
+          ./run_compatibility.sh