Skip to content

Commit 6eaead6

Browse files
Modify wording based on comments on July 24th
1 parent c6f94f6 commit 6eaead6

File tree

3 files changed

+36
-36
lines changed

3 files changed

+36
-36
lines changed

csi.proto

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -383,13 +383,13 @@ message CreateVolumeRequest {
383383
// choose where the provisioned volume is accessible from.
384384
TopologyRequirement accessibility_requirements = 7;
385385

386-
// Plugin specific mutable parameters passed in as opaque key-value
387-
// pairs. This field is OPTIONAL. The Plugin is responsible for
388-
// parsing and validating these parameters. COs will treat these
389-
// as opaque. Plugins MUST treat these as if they take precedence
390-
// over the parameters field.
391-
// COs SHALL NOT provide any values in mutable_parameters if the
392-
// capability is not enabled.
386+
// Plugin specific parameters to apply, passed in as opaque
387+
// key-value pairs. This field is OPTIONAL. The Plugin is
388+
// responsible for parsing and validating these parameters.
389+
// COs will treat these as opaque. Plugins MUST treat these
390+
// as if they take precedence over the parameters field.
391+
// This field SHALL NOT be specified unless the SP has the
392+
// MODIFY_VOLUME plugin capability.
393393
map<string, string> mutable_parameters = 8 [(alpha_field) = true];
394394
}
395395

@@ -1010,12 +1010,12 @@ message ControllerModifyVolumeRequest {
10101010
map<string, string> secrets = 2 [(csi_secret) = true];
10111011

10121012
// Plugin specific parameters to apply, passed in as opaque key-value
1013-
// pairs. This field is OPTIONAL. The Plugin is responsible for
1013+
// pairs. This field is REQUIRED. The Plugin is responsible for
10141014
// parsing and validating these parameters. COs will treat these
1015-
// as opaque. COs MUST specify the intended value of every mutable
1016-
// parameter. Absent keys that were previously assigned a value MUST
1017-
// be interpreted as a deletion of the key from the set of mutable
1018-
// parameters.
1015+
// as opaque. The CO SHOULD specify the intended values of all mutable
1016+
// parameters it intends to modify. SPs MUST NOT modify volumes based
1017+
// on the absence of keys, only keys that are specified should result
1018+
// in modifications to the volume.
10191019
map<string, string> mutable_parameters = 3;
10201020
}
10211021

lib/go/csi/csi.pb.go

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -854,13 +854,13 @@ message CreateVolumeRequest {
854854
// choose where the provisioned volume is accessible from.
855855
TopologyRequirement accessibility_requirements = 7;
856856
857-
// Plugin specific mutable parameters passed in as opaque key-value
858-
// pairs. This field is OPTIONAL. The Plugin is responsible for
859-
// parsing and validating these parameters. COs will treat these
860-
// as opaque. Plugins MUST treat these as if they take precedence
861-
// over the parameters field.
862-
// COs SHALL NOT provide any values in mutable_parameters if the
863-
// capability is not enabled.
857+
// Plugin specific parameters to apply, passed in as opaque
858+
// key-value pairs. This field is OPTIONAL. The Plugin is
859+
// responsible for parsing and validating these parameters.
860+
// COs will treat these as opaque. Plugins MUST treat these
861+
// as if they take precedence over the parameters field.
862+
// This field SHALL NOT be specified unless the SP has the
863+
// MODIFY_VOLUME plugin capability.
864864
map<string, string> mutable_parameters = 8 [(alpha_field) = true];
865865
}
866866
@@ -1668,12 +1668,12 @@ message ControllerModifyVolumeRequest {
16681668
map<string, string> secrets = 2 [(csi_secret) = true];
16691669
16701670
// Plugin specific parameters to apply, passed in as opaque key-value
1671-
// pairs. This field is OPTIONAL. The Plugin is responsible for
1671+
// pairs. This field is REQUIRED. The Plugin is responsible for
16721672
// parsing and validating these parameters. COs will treat these
1673-
// as opaque. COs MUST specify the intended value of every mutable
1674-
// parameter. Absent keys that were previously assigned a value MUST
1675-
// be interpreted as a deletion of the key from the set of mutable
1676-
// parameters.
1673+
// as opaque. The CO SHOULD specify the intended values of all mutable
1674+
// parameters it intends to modify. SPs MUST NOT modify volumes based
1675+
// on the absence of keys, only keys that are specified should result
1676+
// in modifications to the volume.
16771677
map<string, string> mutable_parameters = 3;
16781678
}
16791679

0 commit comments

Comments
 (0)