Add all readability-identifier-naming suppressions for the _3C prefix.

This and the upcoming bulk clang-tidy work will include the unmaintained
clangd3c code because it seems that a modest amount of additional work
can avoid adding many more breakages on top of the ones it already has
(mostly from the upcoming bulk rename).

Author: mattmccutchen-cci

clang-tools-extra/clangd/3CDiagnostics.h

@@ -20,6 +20,9 @@ namespace clang {
 namespace clangd {
 
 // Class that represents diagnostics messages specific to 3C.
+//
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 class _3CDiagnostics {
 public:
   std::mutex DiagMutex;

clang-tools-extra/clangd/ClangdLSPServer.h

@@ -203,6 +203,8 @@ class ClangdLSPServer : private DiagnosticsConsumer {
   llvm::Optional<ClangdServer> Server;
   llvm::Optional<OffsetEncoding> NegotiatedOffsetEncoding;
 #ifdef INTERACTIVE3C
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   _3CInterface &_3CInterface;
 #endif
 };

clang-tools-extra/clangd/ClangdServer.cpp

@@ -99,6 +99,9 @@ ClangdServer::ClangdServer(const GlobalCompilationDatabase &CDB,
                            const FileSystemProvider &FSProvider,
                            DiagnosticsConsumer &DiagConsumer,
 #ifdef INTERACTIVE3C
+                           // See
+                           // clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+                           // NOLINTNEXTLINE(readability-identifier-naming)
                            const Options &Opts, _3CInterface &_3CInterface)
 #else
                            const Options &Opts)

clang-tools-extra/clangd/ClangdServer.h

@@ -61,8 +61,12 @@ class DiagnosticsConsumer {
 };
 
 #ifdef INTERACTIVE3C
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 class _3CLSPCallBack {
 public:
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   virtual void _3CResultsReady(std::string FileName,
                                bool ClearDiags = false) = 0;
   virtual void send3CMessage(std::string MsgStr) = 0;
@@ -170,6 +174,8 @@ class ClangdServer {
                const FileSystemProvider &FSProvider,
 #ifdef INTERACTIVE3C
                DiagnosticsConsumer &DiagConsumer, const Options &Opts,
+               // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+               // NOLINTNEXTLINE(readability-identifier-naming)
                _3CInterface &_3CInterface);
 #else
                DiagnosticsConsumer &DiagConsumer, const Options &Opts);
@@ -312,10 +318,16 @@ class ClangdServer {
 
   void execute3CCommand(ExecuteCommandParams Params, _3CLSPCallBack *ConvCB);
 
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   void _3CCollectAndBuildInitialConstraints(_3CLSPCallBack *ConvCB);
 
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   _3CDiagnostics _3CDiagInfo;
 
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   void _3CCloseDocument(std::string FileName);
 #endif
 
@@ -369,6 +381,8 @@ class ClangdServer {
   // ClangdServer.
   TUScheduler WorkScheduler;
 #ifdef INTERACTIVE3C
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   _3CInterface &_3CInter;
 #endif
 };

clang-tools-extra/clangd/Protocol.h

@@ -724,6 +724,9 @@ llvm::json::Value toJSON(const WorkspaceEdit &WE);
 
 #ifdef INTERACTIVE3C
 /// Data corresponding to the manual fix
+//
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 struct _3CManualFix {
   int ptrID;
 };
@@ -762,8 +765,14 @@ struct ExecuteCommandParams {
   const static llvm::StringLiteral CLANGD_APPLY_TWEAK;
 #ifdef INTERACTIVE3C
   // Command to apply the change for this pointer only
+  //
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   const static llvm::StringLiteral _3C_APPLY_ONLY_FOR_THIS;
   // Command to apply the change for all pointers with same reason
+  //
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   const static llvm::StringLiteral _3C_APPLY_FOR_ALL;
 #endif
 
@@ -773,6 +782,8 @@ struct ExecuteCommandParams {
   // Arguments
   llvm::Optional<WorkspaceEdit> workspaceEdit;
 #ifdef INTERACTIVE3C
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   llvm::Optional<_3CManualFix> _3CManualFix;
 #endif
   llvm::Optional<TweakArgs> tweakArgs;

clang-tools-extra/clangd/tool/ClangdMain.cpp

@@ -280,6 +280,8 @@ static llvm::cl::list<std::string> TweakList(
     llvm::cl::Hidden, llvm::cl::CommaSeparated);
 
 #ifdef INTERACTIVE3C
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 static llvm::cl::OptionCategory _3CCategory("3C", "This is "
                                                   "an interactive version "
                                                   "of 3C "
@@ -481,6 +483,8 @@ int main(int argc, char *argv[]) {
   } else
     CcOptions.AllocatorFunctions = {};
 
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   _3CInterface _3CInterface(CcOptions, OptionsParser.getSourcePathList(),
                             &(OptionsParser.getCompilations()));
 #else

clang/include/clang/3C/3C.h

@@ -23,6 +23,9 @@
 #include <mutex>
 
 // Options used to initialize 3C tool.
+//
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 struct _3COptions {
   bool DumpIntermediate;
 
@@ -65,6 +68,9 @@ struct _3COptions {
 };
 
 // The main interface exposed by the 3C to interact with the tool.
+//
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 class _3CInterface {
 
 public:

clang/tools/3c/3CStandalone.cpp

@@ -19,6 +19,8 @@ using namespace clang::driver;
 using namespace clang::tooling;
 using namespace clang;
 using namespace llvm;
+// See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+// NOLINTNEXTLINE(readability-identifier-naming)
 static cl::OptionCategory _3CCategory("3C options");
 static cl::extrahelp CommonHelp(CommonOptionsParser::HelpMessage);
 static cl::extrahelp MoreHelp("");
@@ -182,6 +184,9 @@ int main(int argc, const char **argv) {
     CcOptions.AllocatorFunctions = {};
 
   // Create 3C Interface.
+  //
+  // See clang/docs/checkedc/3C/clang-tidy.md#_3c-name-prefix
+  // NOLINTNEXTLINE(readability-identifier-naming)
   _3CInterface _3CInterface(CcOptions, OptionsParser.getSourcePathList(),
                             &(OptionsParser.getCompilations()));