Skip to content

Commit 61c141b

Browse files
committed
fix lint
Signed-off-by: SungJin1212 <[email protected]>
1 parent 0f42fae commit 61c141b

File tree

3 files changed

+9
-18
lines changed

3 files changed

+9
-18
lines changed

pkg/cortexpb/histograms.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,3 @@ func spansPromProtoToSpansProto(s []prompb.BucketSpan) []BucketSpan {
155155

156156
return spans
157157
}
158-
159-
func spansWriteV2ProtoToSpansProto(s []writev2.BucketSpan) []BucketSpan {
160-
spans := make([]BucketSpan, len(s))
161-
for i := range s {
162-
spans[i] = BucketSpan{Offset: s[i].Offset, Length: s[i].Length}
163-
}
164-
165-
return spans
166-
}

pkg/cortexpb/timeseriesv2.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ var (
88
expectedSymbols = 20
99

1010
slicePoolV2 = sync.Pool{
11-
New: func() interface{} {
11+
New: func() any {
1212
return make([]PreallocTimeseriesV2, 0, expectedTimeseries)
1313
},
1414
}
1515

1616
timeSeriesPoolV2 = sync.Pool{
17-
New: func() interface{} {
17+
New: func() any {
1818
return &TimeSeriesV2{
1919
LabelsRefs: make([]uint32, 0, expectedLabels),
2020
Samples: make([]Sample, 0, expectedSamplesPerSeries),
@@ -26,7 +26,7 @@ var (
2626
}
2727

2828
writeRequestPoolV2 = sync.Pool{
29-
New: func() interface{} {
29+
New: func() any {
3030
return &PreallocWriteRequestV2{
3131
WriteRequestV2: WriteRequestV2{
3232
Symbols: make([]string, 0, expectedSymbols),

pkg/cortexpb/timeseriesv2_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func BenchmarkMarshallWriteRequestV2(b *testing.B) {
6060
lbs := labels.FromStrings(labels.MetricName, "foo", "labelName1", "labelValue1", "labelName2", "labelValue2", "labelName3", "labelValue3")
6161
st.SymbolizeLabels(lbs, nil)
6262
symbols := st.Symbols()
63-
for i := 0; i < numOfSeries; i++ {
63+
for i := range numOfSeries {
6464
ts = append(ts, PreallocTimeseriesV2{TimeSeriesV2: TimeseriesV2FromPool()})
6565
ts[i].LabelsRefs = []uint32{1, 2, 3, 4, 5, 6, 7, 8}
6666
ts[i].Samples = []Sample{{Value: 1, TimestampMs: 2}}
@@ -69,14 +69,14 @@ func BenchmarkMarshallWriteRequestV2(b *testing.B) {
6969
tests := []struct {
7070
name string
7171
writeRequestFactory func() proto.Marshaler
72-
clean func(in interface{})
72+
clean func(in any)
7373
}{
7474
{
7575
name: "no-pool",
7676
writeRequestFactory: func() proto.Marshaler {
7777
return &WriteRequestV2{Symbols: symbols, Timeseries: ts}
7878
},
79-
clean: func(in interface{}) {},
79+
clean: func(in any) {},
8080
},
8181
{
8282
name: "byte pool",
@@ -86,7 +86,7 @@ func BenchmarkMarshallWriteRequestV2(b *testing.B) {
8686
w.Symbols = symbols
8787
return w
8888
},
89-
clean: func(in interface{}) {
89+
clean: func(in any) {
9090
ReuseWriteRequestV2(in.(*PreallocWriteRequestV2))
9191
},
9292
},
@@ -98,15 +98,15 @@ func BenchmarkMarshallWriteRequestV2(b *testing.B) {
9898
w.Symbols = symbols
9999
return w
100100
},
101-
clean: func(in interface{}) {
101+
clean: func(in any) {
102102
ReuseWriteRequestV2(in.(*PreallocWriteRequestV2))
103103
},
104104
},
105105
}
106106

107107
for _, tc := range tests {
108108
b.Run(tc.name, func(b *testing.B) {
109-
for i := 0; i < b.N; i++ {
109+
for b.Loop() {
110110
w := tc.writeRequestFactory()
111111
_, err := w.Marshal()
112112
require.NoError(b, err)

0 commit comments

Comments
 (0)