Skip to content

Remove references to max_series_per_query from docs #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions docs/configuration/arguments.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,9 @@ overrides:
tenant1:
ingestion_rate: 10000
max_series_per_metric: 100000
max_series_per_query: 100000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably change max_series_per_query to max_fetched_series_per_query as it is the new limit.

tenant2:
max_samples_per_query: 1000000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove max_samples_per_query? It is removed as well

max_series_per_metric: 100000
max_series_per_query: 100000

multi_kv_config:
mirror_enabled: false
Expand All @@ -346,11 +344,9 @@ overrides:
tenant1:
ingestion_rate: 10000
max_series_per_metric: 100000
max_series_per_query: 100000
tenant2:
max_samples_per_query: 1000000
max_series_per_metric: 100000
max_series_per_query: 100000
```

Valid per-tenant limits are (with their corresponding flags for default values):
Expand Down
1 change: 0 additions & 1 deletion docs/guides/overrides-exporter-runtime.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ overrides:
max_series_per_metric: 0
max_series_per_user: 0
max_samples_per_query: 100000
max_series_per_query: 100000
2 changes: 0 additions & 2 deletions docs/guides/overrides-exporter.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ overrides:
max_series_per_metric: 0
max_series_per_user: 0
max_samples_per_query: 100000
max_series_per_query: 100000
```

The `overrides-exporter` is configured to run as follows:
Expand All @@ -59,7 +58,6 @@ cortex_overrides{limit_name="max_global_series_per_user",user="user1"} 300000
cortex_overrides{limit_name="max_local_series_per_metric",user="user1"} 0
cortex_overrides{limit_name="max_local_series_per_user",user="user1"} 0
cortex_overrides{limit_name="max_samples_per_query",user="user1"} 100000
cortex_overrides{limit_name="max_series_per_query",user="user1"} 100000
```

With these metrics, you can set up alerts to know when tenants are close to hitting their limits
Expand Down
Loading