Skip to content

Commit eb32c2d

Browse files
committed
lint fix
1 parent 245982d commit eb32c2d

15 files changed

+56
-56
lines changed

iavl/branch_persisted.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ func (node *BranchPersisted) Get(key []byte) (value []byte, index int64, err err
9999
}
100100

101101
func (node *BranchPersisted) String() string {
102-
//TODO implement me
102+
// TODO implement me
103103
panic("implement me")
104104
}
105105

iavl/changeset_writer.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func (cs *ChangesetWriter) WriteWALCommit(version uint32) error {
4747
return cs.kvlog.WriteCommit(version)
4848
}
4949

50-
func (cs *ChangesetWriter) SaveRoot(root *NodePointer, version uint32, totalLeaves, totalBranches uint32) error {
50+
func (cs *ChangesetWriter) SaveRoot(root *NodePointer, version, totalLeaves, totalBranches uint32) error {
5151
if version != cs.stagedVersion {
5252
return fmt.Errorf("version mismatch: expected %d, got %d", cs.stagedVersion, version)
5353
}
@@ -217,7 +217,7 @@ func (cs *ChangesetWriter) writeLeaf(np *NodePointer, node *MemNode) error {
217217
func (cs *ChangesetWriter) createNodeRef(parentIdx int64, np *NodePointer) NodeRef {
218218
if np.store == cs.reader {
219219
if np.id.IsLeaf() {
220-
//return NodeRef(np.id)
220+
// return NodeRef(np.id)
221221
return NodeRef(NewNodeRelativePointer(true, int64(np.fileIdx)))
222222
} else {
223223
// for branch nodes the relative offset is the difference between the parent ID index and the branch ID index

iavl/commit_multi_tree.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import (
88
"path/filepath"
99
"runtime"
1010

11-
"cosmossdk.io/log"
1211
"github.com/alitto/pond/v2"
1312
dbm "github.com/cosmos/cosmos-db"
1413
protoio "github.com/cosmos/gogoproto/io"
1514

15+
"cosmossdk.io/log"
1616
"cosmossdk.io/store/mem"
1717
"cosmossdk.io/store/metrics"
1818
pruningtypes "cosmossdk.io/store/pruning/types"
@@ -151,7 +151,7 @@ func (db *CommitMultiTree) CacheWrap() storetypes.CacheWrap {
151151
}
152152

153153
func (db *CommitMultiTree) CacheWrapWithTrace(w io.Writer, tc storetypes.TraceContext) storetypes.CacheWrap {
154-
//TODO implement tracking
154+
// TODO implement tracking
155155
return db.CacheMultiStore()
156156
}
157157

@@ -344,7 +344,7 @@ func (db *CommitMultiTree) AddListeners(keys []storetypes.StoreKey) {
344344
}
345345

346346
func (db *CommitMultiTree) PopStateCache() []*storetypes.StoreKVPair {
347-
//TODO implement me
347+
// TODO implement me
348348
panic("implement me")
349349
}
350350

@@ -353,7 +353,7 @@ func (db *CommitMultiTree) SetMetrics(metrics metrics.StoreMetrics) {
353353
}
354354

355355
func LoadDB(path string, opts *Options, logger log.Logger) (*CommitMultiTree, error) {
356-
//n := len(treeNames)
356+
// n := len(treeNames)
357357
//trees := make([]*CommitTree, n)
358358
//treesByName := make(map[string]int, n)
359359
//for i, name := range treeNames {

iavl/commit_tree.go

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"sync/atomic"
88

99
"cosmossdk.io/log"
10-
1110
pruningtypes "cosmossdk.io/store/pruning/types"
1211
storetypes "cosmossdk.io/store/types"
1312
)
@@ -321,8 +320,8 @@ func (c *CommitTree) Close() error {
321320
if c.walChan != nil {
322321
close(c.walChan)
323322
}
324-
//close(c.commitChan)
325-
//return <-c.commitDone
323+
// close(c.commitChan)
324+
// return <-c.commitDone
326325
return c.store.Close()
327326
}
328327

@@ -390,14 +389,16 @@ func evictTraverse(np *NodePointer, depth, evictionDepth uint8, evictVersion uin
390389
}
391390

392391
if memNode.IsLeaf() {
393-
return
392+
return count
394393
}
395394

396395
// Continue traversing to find nodes to evict
397396
count += evictTraverse(memNode.left, depth+1, evictionDepth, evictVersion)
398397
count += evictTraverse(memNode.right, depth+1, evictionDepth, evictVersion)
399-
return
398+
return count
400399
}
401400

402-
var _ storetypes.CommitKVStore = &CommitTree{}
403-
var _ parentTree = &CommitTree{}
401+
var (
402+
_ storetypes.CommitKVStore = &CommitTree{}
403+
_ parentTree = &CommitTree{}
404+
)

iavl/dot_graph.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import (
55
"io"
66
)
77

8-
func DebugTraverse(nodePtr *NodePointer, onNode func(node Node, parent Node, direction string) error) error {
8+
func DebugTraverse(nodePtr *NodePointer, onNode func(node, parent Node, direction string) error) error {
99
if nodePtr == nil {
1010
return nil
1111
}
@@ -52,7 +52,7 @@ func RenderDotGraph(writer io.Writer, nodePtr *NodePointer) error {
5252
return finishGraph()
5353
}
5454

55-
err = DebugTraverse(nodePtr, func(node Node, parent Node, direction string) error {
55+
err = DebugTraverse(nodePtr, func(node, parent Node, direction string) error {
5656
key, err := node.Key()
5757
if err != nil {
5858
return err

iavl/kvlog_writer.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,12 @@ func NewKVDataWriter(file *os.File) *KVLogWriter {
1616
return &KVLogWriter{
1717
FileWriter: fw,
1818
}
19-
2019
}
2120

2221
func (kvs *KVLogWriter) WriteK(key []byte) (offset uint32, err error) {
2322
_, err = kvs.Write([]byte{KVLogEntryTypeExtraK})
2423
if err != nil {
25-
return
24+
return offset, err
2625
}
2726

2827
return kvs.writeLenPrefixedBytes(key)
@@ -31,7 +30,7 @@ func (kvs *KVLogWriter) WriteK(key []byte) (offset uint32, err error) {
3130
func (kvs *KVLogWriter) WriteKV(key, value []byte) (offset uint32, err error) {
3231
_, err = kvs.Write([]byte{KVLogEntryTypeExtraKV})
3332
if err != nil {
34-
return
33+
return offset, err
3534
}
3635

3736
offset, err = kvs.writeLenPrefixedBytes(key)
@@ -95,13 +94,13 @@ func (kvs *KVLogWriter) writeLenPrefixedBytes(key []byte) (offset uint32, err er
9594
// write little endian uint32 length prefix
9695
err = kvs.writeLEU32(uint32(lenKey))
9796
if err != nil {
98-
return
97+
return offset, err
9998
}
10099

101100
// write key bytes
102101
_, err = kvs.Write(key)
103102
if err != nil {
104-
return
103+
return offset, err
105104
}
106105

107106
return offset, nil

iavl/leaf_persisted.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func (node *LeafPersisted) Get(key []byte) (value []byte, index int64, err error
8181
}
8282

8383
func (node *LeafPersisted) String() string {
84-
//TODO implement me
84+
// TODO implement me
8585
panic("implement me")
8686
}
8787

iavl/mem_node.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ func (node *MemNode) String() string {
109109
if node.IsLeaf() {
110110
return fmt.Sprintf("MemNode{key:%x, version:%d, size:%d, value:%x}", node.key, node.version, node.size, node.value)
111111
} else {
112-
113112
return fmt.Sprintf("MemNode{key:%x, version:%d, size:%d, height:%d, left:%s, right:%s}", node.key, node.version, node.size, node.height, node.left, node.right)
114113
}
115114
}

iavl/multi_tree.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func (t *MultiTree) CacheWrap() storetypes.CacheWrap {
2828
}
2929

3030
func (t *MultiTree) CacheWrapWithTrace(w io.Writer, tc storetypes.TraceContext) storetypes.CacheWrap {
31-
//TODO implement tracing
31+
// TODO implement tracing
3232
return t.CacheWrap()
3333
}
3434

@@ -67,12 +67,12 @@ func (t *MultiTree) TracingEnabled() bool {
6767
}
6868

6969
func (t *MultiTree) SetTracer(w io.Writer) storetypes.MultiStore {
70-
//TODO implement me
70+
// TODO implement me
7171
panic("implement me")
7272
}
7373

7474
func (t *MultiTree) SetTracingContext(context storetypes.TraceContext) storetypes.MultiStore {
75-
//TODO implement me
75+
// TODO implement me
7676
panic("implement me")
7777
}
7878

iavl/node_hash.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ func computeHash(node Node, leftHash, rightHash []byte) ([]byte, error) {
2525
return hasher.Sum(nil), nil
2626
}
2727

28-
var (
29-
emptyHash = sha256.New().Sum(nil)
30-
)
28+
var emptyHash = sha256.New().Sum(nil)
3129

3230
// Writes the node's hash to the given `io.Writer`. This function recursively calls
3331
// children to update hashes.

0 commit comments

Comments
 (0)