feat: add block max_gas and min_tip ingestion to app.go mempool config (#582)

* add block max_gas and minimum_gas_prices to app

* add changelog

* move methods out to config

* add godoc

* add tests

* try depot again

* back to gh runner

* fix changelog error

* remove wack evmd argument

* add new flag

* update changelog desc

* change spaces to tab

* repoint constant and add log

* add const docs and change log to warn

* fix lint

* rm flag change

Author: almk-dev

CHANGELOG.md

@@ -25,6 +25,7 @@
 - [\#568](https://github.com/cosmos/evm/pull/568) Avoid unnecessary block notifications when the event bus is already set up.
 - [\#511](https://github.com/cosmos/evm/pull/511) Minor code cleanup for `AddPrecompileFn`.
 - [\#544](https://github.com/cosmos/evm/pull/544) Parse logs from the txResult.Data and avoid emitting EVM events to cosmos-sdk events.
+- [\#582](https://github.com/cosmos/evm/pull/582) Add block max-gas (from genesis.json) and new min-tip (from app.toml/flags) ingestion into mempool config
 
 ### FEATURES
 

config/server_app_options.go

@@ -0,0 +1,94 @@
+package config
+
+import (
+	"math"
+	"path/filepath"
+
+	"github.com/holiman/uint256"
+	"github.com/spf13/cast"
+
+	srvflags "github.com/cosmos/evm/server/flags"
+
+	"cosmossdk.io/log"
+
+	"github.com/cosmos/cosmos-sdk/client/flags"
+	sdkserver "github.com/cosmos/cosmos-sdk/server"
+	servertypes "github.com/cosmos/cosmos-sdk/server/types"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types"
+)
+
+// GetBlockGasLimit reads the genesis json file using AppGenesisFromFile
+// to extract the consensus block gas limit before InitChain is called.
+func GetBlockGasLimit(appOpts servertypes.AppOptions, logger log.Logger) uint64 {
+	homeDir := cast.ToString(appOpts.Get(flags.FlagHome))
+	if homeDir == "" {
+		logger.Error("home directory not found in app options, using zero block gas limit")
+		return math.MaxUint64
+	}
+	genesisPath := filepath.Join(homeDir, "config", "genesis.json")
+
+	appGenesis, err := genutiltypes.AppGenesisFromFile(genesisPath)
+	if err != nil {
+		logger.Error("failed to load genesis using SDK AppGenesisFromFile, using zero block gas limit", "path", genesisPath, "error", err)
+		return 0
+	}
+	genDoc, err := appGenesis.ToGenesisDoc()
+	if err != nil {
+		logger.Error("failed to convert AppGenesis to GenesisDoc, using zero block gas limit", "path", genesisPath, "error", err)
+		return 0
+	}
+
+	if genDoc.ConsensusParams == nil {
+		logger.Error("consensus parameters not found in genesis (nil), using zero block gas limit")
+		return 0
+	}
+
+	maxGas := genDoc.ConsensusParams.Block.MaxGas
+	if maxGas == -1 {
+		logger.Warn("genesis max_gas is unlimited (-1), using max uint64")
+		return math.MaxUint64
+	}
+	if maxGas < -1 {
+		logger.Error("invalid max_gas value in genesis, using zero block gas limit")
+		return 0
+	}
+	blockGasLimit := uint64(maxGas) // #nosec G115 -- maxGas >= 0 checked above
+
+	logger.Debug(
+		"extracted block gas limit from genesis using SDK AppGenesisFromFile",
+		"genesis_path", genesisPath,
+		"max_gas", maxGas,
+		"block_gas_limit", blockGasLimit,
+	)
+
+	return blockGasLimit
+}
+
+// GetMinGasPrices reads the min gas prices from the app options, set from app.toml
+// This is currently not used, but is kept in case this is useful for the mempool,
+// in addition to the min tip flag
+func GetMinGasPrices(appOpts servertypes.AppOptions, logger log.Logger) sdk.DecCoins {
+	minGasPricesStr := cast.ToString(appOpts.Get(sdkserver.FlagMinGasPrices))
+	minGasPrices, err := sdk.ParseDecCoins(minGasPricesStr)
+	if err != nil {
+		logger.With("error", err).Info("failed to parse min gas prices, using empty DecCoins")
+		minGasPrices = sdk.DecCoins{}
+	}
+
+	return minGasPrices
+}
+
+// GetMinTip reads the min tip from the app options, set from app.toml
+// This field is also known as the minimum priority fee
+func GetMinTip(appOpts servertypes.AppOptions, logger log.Logger) *uint256.Int {
+	minTipUint64 := cast.ToUint64(appOpts.Get(srvflags.EVMMinTip))
+	minTip := uint256.NewInt(minTipUint64)
+
+	if minTip.Cmp(uint256.NewInt(0)) >= 0 { // zero or positive
+		return minTip
+	}
+
+	logger.Error("invalid min tip value in app.toml or flag, falling back to nil", "min_tip", minTipUint64)
+	return nil
+}