instantiate.sh: empty-safe expansion for INIT_AGENT_ARGS (fixes #9)

The `--agent=none` path tripped `set -u` on bash 3.2 (macOS default)
because `"${INIT_AGENT_ARGS[@]}"` raises "unbound variable" when the
array is empty. init-wiki.sh never ran and the script exited non-zero.

Switch both call sites to the portable empty-safe form
`${ARR[@]+"${ARR[@]}"}"`, which expands with full per-element quoting
when set and to nothing when empty, on bash 3.2 / 4 / 5.

Adds a regression smoke test `instantiate-agent-none` that bootstraps
the template with `--agent=none` and asserts the wiki is created and
no agent overlay is installed. The macOS CI matrix actually runs
bash 3.2, so this test would have caught the original bug.

Also clears the workaround note from the existing `template-bootstrap`
patch.sh now that `--agent=none` is exercised explicitly.

Local harness: 72 pass, 0 fail (64 baseline + 8 new).

Co-authored-by: Priscila Saboia Moreira <pmoreira@nd.edu>

Author: psaboia

scripts/instantiate.sh

@@ -282,9 +282,9 @@ else
             fi
         fi
 
-        "$REPO_ROOT/wiki/init-wiki.sh" --github "${INIT_AGENT_ARGS[@]}"
+        "$REPO_ROOT/wiki/init-wiki.sh" --github ${INIT_AGENT_ARGS[@]+"${INIT_AGENT_ARGS[@]}"}
     else
-        "$REPO_ROOT/wiki/init-wiki.sh" "${INIT_AGENT_ARGS[@]}"
+        "$REPO_ROOT/wiki/init-wiki.sh" ${INIT_AGENT_ARGS[@]+"${INIT_AGENT_ARGS[@]}"}
     fi
 fi
 

scripts/test-mvp/README.md

@@ -16,6 +16,7 @@ Currently one category. The harness auto-discovers any new categories under
 | Test | Assertions | What it checks |
 |---|---|---|
 | `template-bootstrap` | 14 | Clones the real template, runs `instantiate.sh`, asserts: bash syntax of all shipping scripts, CLAUDE.md generated with substituted placeholders, wiki sub-repo created, namespaced nav files present, `init-wiki.sh` is idempotent |
+| `instantiate-agent-none` | 8 | Regression for issue #9: runs `instantiate.sh --agent=none`, asserts bootstrap completes, CLAUDE.md is written, `init-wiki.sh` runs, and no `.claude/` or `.cursor/` overlay is copied |
 
 ## Usage
 

scripts/test-mvp/tests/smoke/instantiate-agent-none/assertions.sh

@@ -0,0 +1,42 @@
+#!/usr/bin/env bash
+# Assertions for the --agent=none regression smoke test (issue #9).
+#
+# Before the fix, instantiate.sh exited non-zero with
+#   "INIT_AGENT_ARGS[@]: unbound variable"
+# on bash 3.2 and init-wiki.sh never ran. After the fix, the script
+# completes and produces CLAUDE.md + the wiki sub-repo.
+
+T="$SANDBOX/template-none"
+
+if [ ! -d "$T" ]; then
+    skip "instantiate-agent-none assertions" "template not cloned (offline + no MVP_TEMPLATE_LOCAL)"
+    return 0 2>/dev/null || true
+fi
+
+# Bootstrap exit + CLAUDE.md substitution
+assert "instantiate.sh --agent=none produced CLAUDE.md" \
+    "[ -f '$T/CLAUDE.md' ]"
+assert_contains "CLAUDE.md has project name substituted" \
+    "$T/CLAUDE.md" "Agent None Project"
+assert "CLAUDE.md has no {{PROJECT_NAME}} leak" \
+    "! grep -q '{{PROJECT_NAME}}' '$T/CLAUDE.md'"
+
+# init-wiki.sh must have run (the regression killed it before it could fire)
+REPO_NAME=$(basename "$T")
+WIKI_SUB="$T/wiki/${REPO_NAME}.wiki"
+
+assert "wiki sub-repo created at wiki/${REPO_NAME}.wiki/ (init-wiki.sh ran)" \
+    "[ -d '$WIKI_SUB/.git' ]"
+assert "Home_${REPO_NAME}.md exists" \
+    "[ -f '$WIKI_SUB/Home_${REPO_NAME}.md' ]"
+assert "SCHEMA_${REPO_NAME}.md exists" \
+    "[ -f '$WIKI_SUB/SCHEMA_${REPO_NAME}.md' ]"
+
+# --agent=none means no agent-overlay files should have been copied into
+# the project root. The template ships agent overlays under wiki/agents/
+# but instantiate.sh should NOT have created .claude/ or .cursor/ when
+# --agent=none.
+assert "no .claude/ overlay copied when --agent=none" \
+    "[ ! -d '$T/.claude' ]"
+assert "no .cursor/ overlay copied when --agent=none" \
+    "[ ! -d '$T/.cursor' ]"

scripts/test-mvp/tests/smoke/instantiate-agent-none/patch.sh

@@ -0,0 +1,50 @@
+#!/usr/bin/env bash
+# Smoke test: instantiate with --agent=none.
+#
+# Regression coverage for issue #9: instantiate.sh tripped `set -u` on
+# bash 3.2 (macOS default) when INIT_AGENT_ARGS expanded empty for
+# --agent=none, killing the bootstrap before init-wiki.sh could run.
+#
+# This test exercises the no-overlay path end-to-end so the bug cannot
+# return silently. Runs against the macOS matrix where bash 3.2 actually
+# reproduces the original failure.
+#
+# Inputs:  SANDBOX env var. lib/template.sh's clone_template.
+# Effects: $SANDBOX/template-none/ contains a derivative bootstrapped
+#          without any agent overlay.
+#
+# Idempotent.
+
+set -euo pipefail
+
+HARNESS_LIB="$(cd "$(dirname "${BASH_SOURCE[0]}")/../../../lib" && pwd)"
+# shellcheck source=../../../lib/template.sh
+source "$HARNESS_LIB/template.sh"
+
+T="$SANDBOX/template-none"
+
+if [ -d "$T" ]; then
+    echo "  Template-none already cloned at $T (idempotent re-run)."
+elif clone_template "$T"; then
+    echo "  Cloned template to $T."
+else
+    echo "  WARN: could not clone template (no network and no MVP_TEMPLATE_LOCAL)." >&2
+    exit 0
+fi
+
+if [ -f "$T/scripts/instantiate.sh" ]; then
+    (
+        cd "$T"
+        if [ ! -f CLAUDE.md ]; then
+            bash scripts/instantiate.sh "Agent None Project" \
+                --agent=none \
+                --description="Regression test for issue #9 (set -u + empty array)." \
+                >/tmp/instantiate-none.log 2>&1 || {
+                    echo "  WARN: instantiate.sh --agent=none failed; assertions will surface the cause." >&2
+                    cat /tmp/instantiate-none.log | sed 's/^/    /' >&2
+                }
+        fi
+    )
+fi
+
+echo "  Smoke instantiate-agent-none patch applied: template at $T."

scripts/test-mvp/tests/smoke/template-bootstrap/patch.sh

@@ -45,10 +45,10 @@ if [ -f "$T/scripts/instantiate.sh" ]; then
         cd "$T"
         # Only run instantiate if it hasn't already been run (CLAUDE.md absent)
         if [ ! -f CLAUDE.md ]; then
-            # Use --agent=claude-code (the documented default). Note: the
-            # template currently has a 'set -u' bug with empty INIT_AGENT_ARGS
-            # when --agent=none is used; this should be filed upstream.
-            # Using claude-code sidesteps the bug for our smoke test.
+            # Use --agent=claude-code (the documented default) to exercise
+            # the claude-code overlay. The --agent=none path is covered
+            # separately by the instantiate-agent-none smoke test (issue #9
+            # regression).
             bash scripts/instantiate.sh "Smoke Test Project" \
                 --agent=claude-code \
                 --description="Bootstrapping the template inside the harness sandbox." \