chore: make MetadataCacheFactory::writer_props return a Result

srh · web-flow · commit 7e935118e556 · 2024-09-24T01:05:15.000-07:00
diff --git a/datafusion/src/physical_plan/parquet.rs b/datafusion/src/physical_plan/parquet.rs
@@ -153,8 +153,11 @@ pub trait MetadataCacheFactory: Sync + Send {
         time_to_idle: Duration,
     ) -> Arc<dyn ParquetMetadataCache>;
     /// Modifies and builds writer properties.
-    fn build_writer_props(&self, builder: WriterPropertiesBuilder) -> WriterProperties {
-        builder.build()
+    fn build_writer_props(
+        &self,
+        builder: WriterPropertiesBuilder,
+    ) -> Result<WriterProperties> {
+        Ok(builder.build())
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,11 @@ pub trait MetadataCacheFactory: Sync + Send {`
`153`	`153`	`time_to_idle: Duration,`
`154`	`154`	`) -> Arc<dyn ParquetMetadataCache>;`
`155`	`155`	`/// Modifies and builds writer properties.`
`156`		`- fn build_writer_props(&self, builder: WriterPropertiesBuilder) -> WriterProperties {`
`157`		`- builder.build()`
	`156`	`+ fn build_writer_props(`
	`157`	`+ &self,`
	`158`	`+ builder: WriterPropertiesBuilder,`
	`159`	`+ ) -> Result<WriterProperties> {`
	`160`	`+ Ok(builder.build())`
`158`	`161`	`}`
`159`	`162`	`}`
`160`	`163`