Skip to content

feat(FilterListBox): add component #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(FilterListBox): add component #730

wants to merge 16 commits into from

Conversation

tenphi
Copy link
Member

@tenphi tenphi commented Jul 18, 2025

No description provided.

Copy link

changeset-bot bot commented Jul 18, 2025

🦋 Changeset detected

Latest commit: 97d074b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:06am
cube-ui-kit-cursor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2025 11:06am

Copy link
Contributor

github-actions bot commented Jul 18, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-804cf9f.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

🏋️ Size limit report

Name Size Passed?
All 264.44 KB (+0.83% 🔺) No 👎
Tree shaking (just a Button) 21.74 KB (+0.05% 🔺) Yes 🎉
Tree shaking (just an Icon) 11.41 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Contributor

github-actions bot commented Jul 18, 2025

🧪 Storybook is successfully deployed!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Search Comparison Uses Incorrect Property

The doesTermExist function in FilterListBox.tsx incorrectly compares the search term against an item's key instead of its displayed text content (textValue or children). This leads to duplicate custom options being shown when the search term matches an existing item's display text but not its key, as the function fails to identify the existing option. The comparison should be against the item's display text, ideally case-insensitively.

src/components/fields/FilterListBox/FilterListBox.tsx#L341-L351

if (child.type === Item) {
const childText =
child.props.textValue ||
(typeof child.props.children === 'string'
? child.props.children
: '') ||
String(child.props.children ?? '');
if (term === String(child.key)) {
exists = true;
}

Fix in CursorFix in Web


Bug: FieldWrapper Fails to Apply Styles Without Labels

The FieldWrapper component now bypasses its rendering and returns the wrapped component directly when no label prop is provided. This prevents components from receiving essential field-level functionalities, such as validation states, error messages, required indicators, descriptions, and other styling or accessibility features, which are needed regardless of label presence.

src/components/form/wrapper.tsx#L40-L43

if (!label) {
return component;
}

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant