Skip to content

Commit f37c000

Browse files
authored
test(schema-compiler): Replace apla-clickhouse with @clickhouse/client (#8978)
* Fix type annotation for buildSqlAndParams * Rework TEST_CLICKHOUSE_HOST handling * Port ClickHouseDbRunner to TypeScript * Move _normaliseResponse to static method
1 parent d1b07f1 commit f37c000

File tree

5 files changed

+232
-202
lines changed

5 files changed

+232
-202
lines changed

packages/cubejs-schema-compiler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"uuid": "^8.3.2"
5858
},
5959
"devDependencies": {
60-
"@cubejs-backend/apla-clickhouse": "^1.7.0",
60+
"@clickhouse/client": "^1.7.0",
6161
"@cubejs-backend/linter": "^1.0.0",
6262
"@cubejs-backend/query-orchestrator": "1.1.7",
6363
"@types/babel__code-frame": "^7.0.6",

packages/cubejs-schema-compiler/src/adapter/BaseQuery.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -577,9 +577,9 @@ export class BaseQuery {
577577
}
578578

579579
/**
580-
* Returns an array of SQL query strings for the query.
580+
* Returns a pair of SQL query string and parameter values for the query.
581581
* @param {boolean} [exportAnnotatedSql] - returns annotated sql with not rendered params if true
582-
* @returns {Array<string>}
582+
* @returns {[string, Array<unknown>]}
583583
*/
584584
buildSqlAndParams(exportAnnotatedSql) {
585585
if (getEnv('nativeSqlPlanner')) {

packages/cubejs-schema-compiler/test/integration/clickhouse/ClickHouseDbRunner.js

Lines changed: 0 additions & 194 deletions
This file was deleted.

0 commit comments

Comments
 (0)