From 005dc1dbb2d55c688fe898f81820129fcdc2993d Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Mon, 25 Nov 2024 16:10:58 -0800 Subject: [PATCH 1/5] Show a last-failed example --- .github/workflows/e2e.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 7baf321..dbbc988 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -26,10 +26,16 @@ jobs: - name: Reset NX run: npx nx reset + - name: Playwright Last Failed action + id: last-failed-action + uses: currents-dev/playwright-last-failed@v1 + with: + pw-output-dir: playwright-report + - name: Run All E2E Tests env: CURRENTS_API_URL: https://cy-staging.currents.dev CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} - run: npx nx run-many -t e2e --verbose --parallel=2 --base=main~1 --head=HEAD + run: npx nx run-many -t e2e --verbose --parallel=2 --base=main~1 --head=HEAD ${{ steps.last-failed-action.outputs.extra-pw-flags }} From c265b682b1407f01af48382523a5f6cc06e5165e Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Mon, 25 Nov 2024 16:22:11 -0800 Subject: [PATCH 2/5] chore: Try base branch --- .github/workflows/e2e.yml | 2 +- .github/workflows/or8n.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index dbbc988..bf4baca 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -38,4 +38,4 @@ jobs: CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} - run: npx nx run-many -t e2e --verbose --parallel=2 --base=main~1 --head=HEAD ${{ steps.last-failed-action.outputs.extra-pw-flags }} + run: npx nx run-many -t e2e --verbose --parallel=2 --base=main --head=HEAD ${{ steps.last-failed-action.outputs.extra-pw-flags }} diff --git a/.github/workflows/or8n.yml b/.github/workflows/or8n.yml index b530a95..0a5508c 100644 --- a/.github/workflows/or8n.yml +++ b/.github/workflows/or8n.yml @@ -32,4 +32,4 @@ jobs: CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} - run: npx nx run-many -t or8n --verbose --base=main~1 --head=HEAD + run: npx nx run-many -t or8n --verbose --base=main --head=HEAD From 2008ae5d448c97bd408e439fe263b6dda39c0bdf Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Mon, 25 Nov 2024 16:31:42 -0800 Subject: [PATCH 3/5] chore: drop affected flags for example --- .github/workflows/e2e.yml | 2 +- .github/workflows/or8n.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index bf4baca..6122d7b 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -38,4 +38,4 @@ jobs: CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} - run: npx nx run-many -t e2e --verbose --parallel=2 --base=main --head=HEAD ${{ steps.last-failed-action.outputs.extra-pw-flags }} + run: npx nx run-many -t e2e --verbose --parallel=2 ${{ steps.last-failed-action.outputs.extra-pw-flags }} diff --git a/.github/workflows/or8n.yml b/.github/workflows/or8n.yml index 0a5508c..6880a15 100644 --- a/.github/workflows/or8n.yml +++ b/.github/workflows/or8n.yml @@ -32,4 +32,4 @@ jobs: CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} - run: npx nx run-many -t or8n --verbose --base=main --head=HEAD + run: npx nx run-many -t or8n --verbose From 044ead08e0ed8b74e606c12b283737035096d9fd Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Mon, 25 Nov 2024 16:36:57 -0800 Subject: [PATCH 4/5] chore: Use the defualt ci-build-id --- .github/workflows/e2e.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 6122d7b..79e8a57 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -34,8 +34,6 @@ jobs: - name: Run All E2E Tests env: - CURRENTS_API_URL: https://cy-staging.currents.dev CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} - CURRENTS_CI_BUILD_ID: ${{ github.run_id }}-${{ github.sha }} run: npx nx run-many -t e2e --verbose --parallel=2 ${{ steps.last-failed-action.outputs.extra-pw-flags }} From 28f251b3c9ef292435b6ead700f8868f3f7d4fd6 Mon Sep 17 00:00:00 2001 From: DJ Mountney Date: Mon, 25 Nov 2024 16:41:34 -0800 Subject: [PATCH 5/5] chore: Move env up --- .github/workflows/e2e.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 79e8a57..96cc809 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -15,6 +15,9 @@ jobs: strategy: matrix: shard: [1, 2, 3] + env: + CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} + CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} steps: - name: Checkout repository @@ -33,7 +36,4 @@ jobs: pw-output-dir: playwright-report - name: Run All E2E Tests - env: - CURRENTS_PROJECT_ID: ${{secrets.CURRENTS_PROJECT_ID}} - CURRENTS_RECORD_KEY: ${{secrets.CURRENTS_RECORD_KEY}} run: npx nx run-many -t e2e --verbose --parallel=2 ${{ steps.last-failed-action.outputs.extra-pw-flags }}