Review and revise saving to a repo you don't have writing permissions to.

[ilovan]

Expected Behaviour

Check for writing permissions before going through (this repo exists, etc.)

Steps to Reproduce (for bugs)

1. Open a repo you don't have writing permission to (e.g. https://dev-cwrc-writer.cwrc.ca/?githubPath=document.xml&githubRepo=SusanBrown%2FDTOC-Template)
2. Make a change
3. Hit Save on the ribbon
   Result:

[ajmacdonald]

As part of this rework, I'm wondering if it makes sense to keep the additional "this repository exists - would you like to use it" confirmation? @ilovan

[ilovan]

can you condense it into "this repository and document path exist - would you like to use them?

[ajmacdonald]

Not easily because those are two separate checks that happen at different points in the saving process. Not to mention the case where the repository exists but the document path doesn't.

I just think it seems a bit redundant to ask the user if they really want to use the repository that they've already specified.

[ilovan]

right, but at the same time, the users should be warned if they are creating a new repo. So maybe instead of "this repository exists - would you like to use it" how about if the message "the repository you specified does not exist yet - would you like to create it?" (basically reverse the check)
maybe do the same for the second check as well.

[ajmacdonald]

I agree.

[ilovan]

actually, the second file already follows the logic I just described for the repo check - so no need to change that.

[ajmacdonald]

cwrc/cwrc-git-dialogs@ec18e26

[ilovan]

confirmed on dev-cwrc-writer