CORE-2057 Fix Admin EditTool form#638
Merged
psarando merged 6 commits intocyverse-de:mainfrom Jun 13, 2025
Merged
Conversation
When an admin attempted to edit a tool, a null tool error in the service facade prevented the PATCH request from being submitted. The `handleSubmit` function was setting the formatted values in a `toolSubmission` state, then immediately calling `updateCurrentTool` or `addNewTool` mutation queries, which were trying to access that state, but the state values were not available yet.
Member
Author
|
I'm going to merge this right away, but reviews are still welcome 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix a bug in the Admin EditTool form, where an admin attempted to edit a tool and a null tool error in the service facade prevented the PATCH request from being submitted.
The
handleSubmitfunction was setting the formatted values in atoolSubmissionstate, then immediately callingupdateCurrentTooloraddNewToolmutation queries, which were trying to access that state, but the state values were not available yet.This PR also includes other minor fixes, such as fixing warnings and the tool edit success announcement.