CORE-2095: fix a problem with HTTP 413 status codes being returned when saving large files.#642
Merged
slr71 merged 3 commits intocyverse-de:mainfrom Nov 4, 2025
Merged
CORE-2095: fix a problem with HTTP 413 status codes being returned when saving large files.#642slr71 merged 3 commits intocyverse-de:mainfrom
slr71 merged 3 commits intocyverse-de:mainfrom
Conversation
👍
Member
Author
|
Thanks for the review! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, a 413 error would occur any time a user was using the editor feature in the DE to modify and save a file that is more than approximately 100kb in size because the default maximum request body size for express.js is 100kb. This value is configurable, so the solution is to specify it when loading express.js. The default maximum file size supported by the editor in the DE is 8mb, so the maximum request body size should be a little bit larger than that.
For this change, I chose to make the default maximum request body size 10mb and to make it configurable just in case we need to modify it.