Skip to content

Commit 52b060a

Browse files
committed
chores(test): upgrade karma and jasmine dependencies
Jasmine 3.x introduces randomised order in tests, which we can't support for the webpack tests, so we disabled it. Otherwise everything works fine (tested by commenting out some tests).
1 parent 0f57ea5 commit 52b060a

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

package.json

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,15 @@
2626
"eslint": "^3.8.1",
2727
"gulp": "^4.0.0",
2828
"gulp-standard": "^8.0.4",
29-
"jasmine-core": "^2.5.2",
3029
"jquery": "^3.1.1",
3130
"jshint": "^2.9.4",
3231
"jshint-stylish": "^2.2.1",
33-
"karma": "^1.3.0",
34-
"karma-chrome-launcher": "^2.0.0",
35-
"karma-coverage": "^1.1.1",
36-
"karma-firefox-launcher": "^1.0.0",
37-
"karma-jasmine": "^1.0.2",
38-
"karma-phantomjs-launcher": "^1.0.2",
32+
"karma": "^5.0.0",
33+
"karma-chrome-launcher": "^3.1.0",
34+
"karma-coverage": "^2.0.2",
35+
"karma-firefox-launcher": "^1.3.0",
36+
"karma-jasmine": "^3.1.1",
37+
"karma-phantomjs-launcher": "^1.0.4",
3938
"karma-threshold-reporter": "^0.1.15",
4039
"karma-webpack": "^4.0.2",
4140
"lodash": "^4.16.4",

test/webpack/karma.conf.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,13 @@ module.exports = function(config) {
7070

7171
// Concurrency level
7272
// how many browser should be started simultaneous
73-
concurrency: Infinity
73+
concurrency: Infinity,
74+
75+
// Webpack tests need the tests to run in order in order to test the require call
76+
client: {
77+
jasmine: {
78+
random: false
79+
}
80+
},
7481
});
7582
};

0 commit comments

Comments
 (0)