Update optional parameter types in storePayment method

damms005 · damms005 · commit ff8f1e1b2007 · 2025-05-29T08:31:34.000+01:00
diff --git a/src/Services/PaymentHandlers/BasePaymentHandler.php b/src/Services/PaymentHandlers/BasePaymentHandler.php
@@ -76,7 +76,7 @@ public function getTransactionReferenceName(): string
      * This method should also create a record for this transaction in the database payments table.
      *
      */
-    public function storePaymentAndShowUserBeforeProcessing(?int $user_id, $original_amount_displayed_to_user, string $transaction_description, $currency, string $transaction_reference, string $completion_url = null, Request $optionalRequestForEloquentModelLinkage = null, $preferredView = null, ?array $metadata = null)
+    public function storePaymentAndShowUserBeforeProcessing(?int $user_id, $original_amount_displayed_to_user, string $transaction_description, $currency, string $transaction_reference, ?string $completion_url = null, ?Request $optionalRequestForEloquentModelLinkage = null, $preferredView = null, ?array $metadata = null)
     {
         $payment = (new CreateNewPayment())->execute(
             $this->getUniquePaymentHandlerName(),

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function getTransactionReferenceName(): string`
`76`	`76`	`* This method should also create a record for this transaction in the database payments table.`
`77`	`77`	`*`
`78`	`78`	`*/`
`79`		`- public function storePaymentAndShowUserBeforeProcessing(?int $user_id, $original_amount_displayed_to_user, string $transaction_description, $currency, string $transaction_reference, string $completion_url = null, Request $optionalRequestForEloquentModelLinkage = null, $preferredView = null, ?array $metadata = null)`
	`79`	`+ public function storePaymentAndShowUserBeforeProcessing(?int $user_id, $original_amount_displayed_to_user, string $transaction_description, $currency, string $transaction_reference, ?string $completion_url = null, ?Request $optionalRequestForEloquentModelLinkage = null, $preferredView = null, ?array $metadata = null)`
`80`	`80`	`{`
`81`	`81`	`$payment = (new CreateNewPayment())->execute(`
`82`	`82`	`$this->getUniquePaymentHandlerName(),`