fixes after merge, lint

Signed-off-by: Filinto Duran <[email protected]>

Author: filintod

durabletask/aio/__init__.py

@@ -21,6 +21,7 @@
     WhenAnyResultAwaitable,
     gather,
 )
+from .client import AsyncTaskHubGrpcClient
 
 # Compatibility protocol (core functionality only)
 from .compatibility import OrchestrationContextProtocol, ensure_compatibility
@@ -46,8 +47,6 @@
     sandbox_strict,
 )
 
-from .client import AsyncTaskHubGrpcClient
-
 __all__ = [
     "AsyncTaskHubGrpcClient",
     # Core classes

durabletask/aio/awaitables.py

@@ -431,7 +431,7 @@ def __repr__(self) -> str:  # pragma: no cover
             return _CompletedProxy(self._tasks_like[0], completed)
 
         # Map completed task back to the original item and return proxy
-        for original, under in zip(self._tasks_like, underlying):
+        for original, under in zip(self._tasks_like, underlying, strict=False):
             if completed == under:
                 return _CompletedProxy(original, completed)
 

durabletask/aio/sandbox.py

@@ -26,6 +26,9 @@
 
 from .errors import NonDeterminismWarning, SandboxViolationError
 
+# Capture environment variable at module load to avoid triggering non-determinism detection
+_DISABLE_DETECTION = os.getenv("DAPR_WF_DISABLE_DETECTION") == "true"
+
 
 class SandboxMode(str, Enum):
     """Sandbox mode options.
@@ -295,8 +298,8 @@ def __enter__(self) -> "_Sandbox":
 
         # Expose originals/mode to the async workflow context for controlled unsafe access
         try:
-            setattr(self.async_ctx, "_sandbox_originals", dict(self.originals))
-            setattr(self.async_ctx, "_sandbox_mode", self.mode)
+            self.async_ctx._sandbox_originals = dict(self.originals)
+            self.async_ctx._sandbox_mode = self.mode
         except Exception:
             # Context may not support attribute assignment; ignore
             pass
@@ -398,7 +401,7 @@ def __await__(self) -> Any:
                 now_dt = None
         if now_dt is None:
             if hasattr(self.async_ctx, "current_utc_datetime"):
-                now_dt = getattr(self.async_ctx, "current_utc_datetime")
+                now_dt = self.async_ctx.current_utc_datetime
             else:
                 base = getattr(self.async_ctx, "_base_ctx", None)
                 now_dt = getattr(base, "current_utc_datetime", None) if base is not None else None
@@ -407,7 +410,7 @@ def __await__(self) -> Any:
         rng = deterministic_random(iid or "", now_dt)
         # Mark as deterministic so the detector can whitelist bound method calls
         try:
-            setattr(rng, "_dt_deterministic", True)
+            rng._dt_deterministic = True
         except Exception:
             pass
 
@@ -581,10 +584,10 @@ async def _run_mixed() -> list[Any]:
                     else:
                         wf_group = wf_items
                     wf_results: list[Any] = await WhenAllAwaitable(wf_group)  # type: ignore[assignment]
-                    for pos, val in zip(wf_indices, wf_results):
+                    for pos, val in zip(wf_indices, wf_results, strict=False):
                         merged[pos] = val
                 # Then process native sequentially, honoring return_exceptions
-                for pos, it in zip(native_indices, native_items):
+                for pos, it in zip(native_indices, native_items, strict=False):
                     try:
                         merged[pos] = await it
                     except Exception as e:  # noqa: BLE001
@@ -737,8 +740,8 @@ def sandbox_scope(async_ctx: Any, mode: Union[str, SandboxMode]) -> Any:
     if mode_str not in valid_modes:
         raise ValueError(f"Invalid sandbox mode '{mode_str}'. Must be one of {valid_modes}")
 
-    # Check for global disable
-    if mode_str != "off" and os.getenv("DAPR_WF_DISABLE_DETECTION") == "true":
+    # Check for global disable (captured at module load to avoid non-determinism detection)
+    if mode_str != "off" and _DISABLE_DETECTION:
         mode_str = "off"
 
     with _Sandbox(async_ctx, mode_str):

durabletask/client.py

@@ -57,7 +57,6 @@ def raise_if_failed(self):
                 self.failure_details,
             )
 
-
     def to_json(self) -> Any:
         """Parse serialized_output as JSON and return the resulting object.
 

durabletask/deterministic.py

@@ -92,7 +92,7 @@ def random(self) -> random.Random:
         )
         # Mark as deterministic for sandbox detector whitelisting of bound methods
         try:
-            setattr(rnd, "_dt_deterministic", True)
+            rnd._dt_deterministic = True
         except Exception:
             pass
         return rnd

durabletask/internal/shared.py

@@ -6,7 +6,7 @@
 import logging
 import os
 from types import SimpleNamespace
-from typing import Any, Dict, Iterable, Optional, Sequence, Union
+from typing import Any, Optional, Sequence, Union
 
 import grpc
 

durabletask/task.py

@@ -382,7 +382,6 @@ def get_completed_tasks(self) -> int:
 
 
 class CompletableTask(Task[T]):
-    def __init__(self):
     def __init__(self) -> None:
         super().__init__()
         self._retryable_parent: Optional["RetryableTask[Any]"] = None

durabletask/worker.py

@@ -10,7 +10,7 @@
 from datetime import datetime, timedelta
 from threading import Event, Thread
 from types import GeneratorType
-from typing import Any, Callable, Dict, Generator, Optional, Sequence, TypeVar, Union
+from typing import Any, Callable, Generator, Optional, Sequence, TypeVar, Union
 
 import grpc
 from google.protobuf import empty_pb2

tests/aio/test_e2e.py

@@ -37,7 +37,7 @@ def _log_orchestration_progress(
         try:
             st = hub_client.get_orchestration_state(instance_id, fetch_payloads=True)
             if st is None:
-                print(f"[async e2e] state: None")
+                print("[async e2e] state: None")
             else:
                 status_name = st.runtime_status.name
                 if status_name != last_status:
@@ -336,7 +336,7 @@ async def when_any_event_or_timeout(ctx: AsyncWorkflowContext, event_name: str)
                 val = winner.get_result()
                 print(f"[E2E] when_any_event_or_timeout winner=event val={val}")
                 return {"winner": "event", "val": val}
-            print(f"[E2E] when_any_event_or_timeout winner=timeout")
+            print("[E2E] when_any_event_or_timeout winner=timeout")
             return {"winner": "timeout"}
 
         cls.when_any_event_or_timeout = when_any_event_or_timeout

tests/aio/test_gather_behavior.py

@@ -81,5 +81,5 @@ def test_gather_return_exceptions_wraps_children() -> None:
     # The underlying tasks_like should be SwallowExceptionAwaitable instances
     assert isinstance(wa, WhenAllAwaitable)
     # Access internal for type check
-    wrapped: List[Any] = getattr(wa, "_tasks_like")  # type: ignore[attr-defined]
+    wrapped: List[Any] = wa._tasks_like  # type: ignore[attr-defined]
     assert all(isinstance(w, SwallowExceptionAwaitable) for w in wrapped)