Skip to content

Commit d5be542

Browse files
Yao Yaoyaron2
andauthored
fix readme.md (#153)
* fix readme.md * fix readme.md * fix readme.md * fix readme.md * fix grpc readme.md * fix grpc readme.md Co-authored-by: Yaron Schneider <[email protected]>
1 parent 7f6e8c9 commit d5be542

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

service/grpc/Readme.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,22 @@ if err := s.Start(); err != nil {
4444
To handle events from specific topic you need to add at least one topic event handler before starting the service:
4545

4646
```go
47-
if err := s.AddTopicEventHandler("messages", "topic1", eventHandler); err != nil {
47+
sub := &common.Subscription{
48+
PubsubName: "messages",
49+
Topic: "topic1",
50+
}
51+
if err := s.AddTopicEventHandler(sub, eventHandler); err != nil {
4852
log.Fatalf("error adding topic subscription: %v", err)
4953
}
5054
```
5155

5256
The handler method itself can be any method with the expected signature:
5357

5458
```go
55-
func eventHandler(ctx context.Context, e *daprd.TopicEvent) error {
59+
func eventHandler(ctx context.Context, e *common.TopicEvent) (retry bool, err error) {
5660
log.Printf("event - PubsubName:%s, Topic:%s, ID:%s, Data: %v", e.PubsubName, e.Topic, e.ID, e.Data)
5761
// do something with the event
58-
return nil
62+
return true, nil
5963
}
6064
```
6165

service/http/Readme.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ Or with address and an existing `http.ServeMux` in case you want to combine exis
1919
```go
2020
mux := http.NewServeMux()
2121
mux.HandleFunc("/", myOtherHandler)
22-
s := daprd.NewService(":8080", mux)
22+
s := daprd.NewServiceWithMux(":8080", mux)
2323
```
2424

2525
Once you create a service instance, you can "attach" to that service any number of event, binding, and service invocation logic handlers as shown below. Onces the logic is defined, you are ready to start the service:
2626

2727
```go
28-
if err = s.Start(); err != nil && err != http.ErrServerClosed {
28+
if err := s.Start(); err != nil && err != http.ErrServerClosed {
2929
log.Fatalf("error: %v", err)
3030
}
3131
```
@@ -49,10 +49,10 @@ if err != nil {
4949
The handler method itself can be any method with the expected signature:
5050

5151
```go
52-
func eventHandler(ctx context.Context, e *common.TopicEvent) error {
52+
func eventHandler(ctx context.Context, e *common.TopicEvent) (retry bool, err error) {
5353
log.Printf("event - PubsubName:%s, Topic:%s, ID:%s, Data: %v", e.PubsubName, e.Topic, e.ID, e.Data)
5454
// do something with the event
55-
return nil
55+
return true, nil
5656
}
5757
```
5858

0 commit comments

Comments
 (0)