Add some nil test cases to the crypto pkg

Signed-off-by: Tiago Scolari <[email protected]

Author: tscolari

client/internal/crypto/helpers_test.go

@@ -1,6 +1,7 @@
 package crypto_test
 
 import (
+	"reflect"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -33,6 +34,14 @@ func TestPayloadMethods(t *testing.T) {
 			protoMsg:  &runtimev1.DecryptResponse{},
 			inputData: []byte("test data"),
 		},
+		"with nil proto message": {
+			protoMsg:  nilValue[runtimev1.EncryptRequest](),
+			inputData: []byte("test data"),
+		},
+		"with nil input data": {
+			protoMsg:  &runtimev1.EncryptRequest{},
+			inputData: nil,
+		},
 	}
 
 	for name, tc := range testCases {
@@ -57,6 +66,11 @@ func TestPayloadMethods(t *testing.T) {
 				require.Failf(t, "unsupported proto message type", "the type was %T", r)
 			}
 
+			if reflect.ValueOf(tc.protoMsg).IsNil() {
+				assert.Nil(t, outputPayload.GetData(), "the payload should be nil")
+				return
+			}
+
 			assert.Equal(t, tc.inputData, outputPayload.GetData(), "payload should match the input")
 		})
 	}
@@ -79,6 +93,16 @@ func TestSetOptions(t *testing.T) {
 				KeyName: "testing",
 			},
 		},
+		"with nil proto message": {
+			protoMsg: nilValue[runtimev1.EncryptRequest](),
+			options: &runtimev1.EncryptRequestOptions{
+				KeyName: "testing",
+			},
+		},
+		"with nil options": {
+			protoMsg: &runtimev1.EncryptRequest{},
+			options:  nilValue[runtimev1.EncryptRequestOptions](),
+		},
 	}
 
 	for name, tc := range testCases {
@@ -96,6 +120,11 @@ func TestSetOptions(t *testing.T) {
 				require.Failf(t, "unsupported proto message type", "the type was %T", r)
 			}
 
+			if reflect.ValueOf(tc.protoMsg).IsNil() {
+				assert.Nil(t, outputOptions, "the payload should be nil")
+				return
+			}
+
 			assert.Equal(t, tc.options, outputOptions, "options should be persisted")
 		})
 	}
@@ -117,6 +146,12 @@ func TestReset(t *testing.T) {
 		"DecryptResponse": {
 			protoMsg: &runtimev1.DecryptResponse{Payload: &commonv1.StreamPayload{Data: []byte("test data")}},
 		},
+		"with nil proto message": {
+			protoMsg: nilValue[runtimev1.EncryptRequest](),
+		},
+		"with nil payload": {
+			protoMsg: &runtimev1.EncryptRequest{Payload: nil},
+		},
 	}
 
 	for name, tc := range testCases {
@@ -144,3 +179,7 @@ func TestReset(t *testing.T) {
 		})
 	}
 }
+
+func nilValue[T any]() *T {
+	return nil
+}