Skip to content

Commit d295989

Browse files
committed
fix build issues
1 parent 94814d9 commit d295989

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

cpp-backend-new/src/skills/SkillCondition.cpp

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,19 @@
11
#include "SkillCondition.hpp"
2+
#include "../combatants/Combatant.hpp"
23

3-
bool SkillCondition::isMet(const Combatant self, const Combatant target) const
4+
SkillCondition::SkillCondition(ConditionType condition_type, EffectType trigger_requirement)
5+
: condition_type {condition_type},
6+
trigger_requirement { trigger_requirement }
7+
{}
8+
9+
bool SkillCondition::isMet(const Combatant& self, const Combatant& target) const
410
{
511
switch(condition_type)
612
{
713
case ConditionType::HAS_EFFECT_SELF:
8-
return self.checkEffectActive(effect_type);
14+
return self.checkEffectActive(trigger_requirement);
915
case ConditionType::HAS_EFFECT_TARGET:
10-
return target.checkEffectActive(effect_type);
16+
return target.checkEffectActive(trigger_requirement);
1117
case ConditionType::TROOP_COUNT_GREATER_THAN_TARGET:
1218
return self.getTroops() > target.getTroops();
1319
}

cpp-backend-new/src/skills/SkillCondition.hpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,17 @@
44
#include <optional>
55
#include "ConditionType.hpp"
66
#include "../effects/EffectType.hpp"
7-
#include "../combatants/Combatant.hpp"
7+
8+
class Combatant; // Forward declaration
89

910
struct SkillCondition
1011
{
1112
public:
12-
bool isMet(const Combatant self, const Combatant target) const;
13+
SkillCondition(ConditionType condition_type, EffectType trigger_requirement);
14+
bool isMet(const Combatant& self, const Combatant& target) const;
1315
private:
14-
const ConditionType condition_type;
15-
const EffectType effect_type;
16+
ConditionType condition_type;
17+
EffectType trigger_requirement;
1618
};
1719

1820
#endif

cpp-backend-new/src/skills/StatusSkill.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#include "StatusSkill.hpp"
22

3-
StatusSkill::StatusSkill(const TimedEffect status_effect, const SkillType skill_type, const EffectType effect_type)
4-
: Skill(skill_type, effect_type), status_effect(status_effect)
3+
StatusSkill::StatusSkill(const TimedEffect status_effect, const SkillType skill_type, const EffectType effect_type, const SkillCondition skill_condition)
4+
: Skill(skill_type, effect_type, skill_condition),
5+
status_effect(status_effect)
56
{}
67

78
void StatusSkill::onDependent(Combatant& combatant_friendly, Combatant& combatant_enemy) const

cpp-backend-new/src/skills/StatusSkill.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class Combatant;
1313
class StatusSkill: public Skill
1414
{
1515
public:
16-
StatusSkill(const TimedEffect status_effect, const SkillType skill_type, const EffectType effect_type);
16+
StatusSkill(const TimedEffect status_effect, const SkillType skill_type, const EffectType effect_type, const SkillCondition skill_condition);
1717
void onDependent(Combatant& friendly_combatant, Combatant& enemy_combatant) const override;
1818
bool operator==(const Skill& other) const override;
1919
std::vector<CombatantEvent> getTriggerEvents() const;

0 commit comments

Comments
 (0)