feat(proto): add examples to remaining schema fields#29
Merged
cooper (czxtm) merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
Ensures every scalar field across the .proto.nix schemas carries a realistic example so the demo agent (and future generated MSW handler stubs) can synthesize mock data that mirrors real environments. Fills in the four schemas where fields were still bare: - dns: zones, records, TTLs, proxied flags - users: names, GitHub handles, emails, AGE keys - secrets (deprecated SecretsGroup): legacy SOPS/SSM/vals refs - github-collaborators: login, id, role, public keys https://claude.ai/code/session_01HYhEk7cpz8hRS32Yo1TV9e
PR SummaryLow Risk Overview These examples flow into generated Reviewed by Cursor Bugbot for commit f6e63a2. Configure here. |
cooper (czxtm)
added a commit
that referenced
this pull request
May 2, 2026
…mples-9xeiz feat(proto): add examples to remaining schema fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings every scalar field across the
.proto.nixschemas up to full example coverage so the demo agent (and the planned proto-driven MSW handler generator) has enough material to synthesize mock data that feels like a real environment.Coverage check after this change — every scalar field in every non-template schema now resolves to a
withExample(ormkField { example = ... }):Files touched
dns.proto.nix— TTLs, zones, records, proxied flagsusers.proto.nix— names, GitHub handles, emails, AGE keyssecrets.proto.nix— legacySecretsGroupSOPS/SSM/vals refsexternal/github-collaborators.proto.nix— login, id, role, SSH keysThe remaining 18 schemas (apps, aws, config, databases, deployment, extensions, files, healthchecks, modules, onboarding, scripts, services, shells, sst, step-ca, tasks, theme, variables) already had examples on every scalar field — verified by inspection.
Why this helps the demo
Examples flow through
nix/stackpanel/db/lib/proto.nix→ generated.proto// (example: …)comments → protobuf-ts JSDoc on TS types. The demo agent's MSW handler layer (apps/web/src/demo/handlers.ts) is on a path to be generated from these descriptors perapps/web/src/demo/README.md; once that lands, every field already has a sensible default mock value rather than""/0/false.Test plan
./packages/proto/generate.shregenerates.protofiles cleanlyvp check(Nix eval + lint) passes.proto(e.g.dns.proto) to confirm// (example: …)comments appear on every scalar field/demo) still boots without console errorshttps://claude.ai/code/session_01HYhEk7cpz8hRS32Yo1TV9e
Generated by Claude Code