refactor: unify gRPC message size into single config value (#19397)

* refactor: unify gRPC message size into single config value

Consolidate `grpc_max_encoding_size` and `grpc_max_decoding_size` into
a single `grpc_max_message_size` parameter since they are always set
together. Also change the parameter type from `Option<usize>` to `usize`
to require explicit values at construction time.

Changes:
- Unify encoding/decoding size into `grpc_max_message_size` in `RaftConfig` and `GrpcConfig`
- Change `RpcClientConf.grpc_max_message_size` from `Option<usize>` to `usize`
- Change `MetaGrpcClient::try_create()` and `try_create_with_features()` params to `usize`
- Export `DEFAULT_GRPC_MESSAGE_SIZE` from `databend-common-meta-client`
- Update all call sites to use `DEFAULT_GRPC_MESSAGE_SIZE` explicitly
- Remove unused dependencies: `chrono`, `chrono-tz` from `databend-common-io`, `databend-common-column` from `databend-common-hashtable`, `chrono-tz` from `databend-common-formats`

Config example (databend-meta):

```toml
# MetaService gRPC message size (default: 32MB)
grpc_api_max_message_size = 67108864  # 64MB

[raft_config]
# Raft gRPC message size (default: 32MB)
raft_grpc_max_message_size = 67108864  # 64MB
```

Config example (databend-query):

```toml
[meta]
# Meta client gRPC message size (default: 32MB)
grpc_max_message_size = 67108864  # 64MB
```

* M  src/query/service/tests/it/storages/testdata/configs_table_basic.txt

Author: drmingdrmer

Cargo.lock

@@ -8,7 +8,6 @@ edition = { workspace = true }
 
 [dependencies]
 databend-common-base = { workspace = true }
-databend-common-column = { workspace = true }
 ## Must disable feature "runtime-rng", it will make the hash results unstable in cluster
 ahash = { workspace = true, features = ["no-rng"] }
 bumpalo = { workspace = true }

src/common/hashtable/Cargo.toml

@@ -12,8 +12,6 @@ bincode = { workspace = true }
 borsh = { workspace = true }
 byteorder = { workspace = true }
 bytes = { workspace = true }
-chrono = { workspace = true }
-chrono-tz = { workspace = true }
 databend-common-base = { workspace = true }
 databend-common-exception = { workspace = true }
 databend-common-timezone = { workspace = true }

src/common/io/Cargo.toml

@@ -143,9 +143,11 @@ pub async fn entry<RT: RuntimeApi>(conf: MetaConfig) -> anyhow::Result<()> {
         println!("      Status: {}", single_or_join);
         println!();
         let grpc_listen = conf.service.grpc.api_address().unwrap_or_else(|| "-".to_string());
+        let max_message = r.raft_grpc_max_message_size();
         println!("HTTP API listen at: {}", conf.admin.api_address);
         println!("gRPC API listen at: {} advertise: {}", grpc_listen, grpc_advertise);
-        println!("Raft API listen at: {} advertise: {}", raft_listen, raft_advertise,);
+        println!("Raft API listen at: {} advertise: {}", raft_listen, raft_advertise);
+        println!("Raft API max message: {}MB", max_message / (1024 * 1024));
         println!();
     }
 

src/meta/binaries/meta/entry.rs

@@ -43,6 +43,7 @@ use databend_common_meta_app::schema::TableNameIdent;
 use databend_common_meta_app::schema::UpsertTableOptionReq;
 use databend_common_meta_app::schema::database_name_ident::DatabaseNameIdent;
 use databend_common_meta_app::tenant::Tenant;
+use databend_common_meta_client::DEFAULT_GRPC_MESSAGE_SIZE;
 use databend_common_meta_client::MetaGrpcClient;
 use databend_common_meta_client::required;
 use databend_common_meta_kvapi::kvapi::KVApi;
@@ -138,6 +139,7 @@ async fn main() {
         None,
         None,
         required::read_write(),
+        DEFAULT_GRPC_MESSAGE_SIZE,
     )
     .unwrap();
     let client = MetaStore::R(client_handle);

src/meta/binaries/metabench/main.rs

@@ -23,6 +23,7 @@ use clap::CommandFactory;
 use clap::Parser;
 use clap::Subcommand;
 use databend_common_meta_client::ClientHandle;
+use databend_common_meta_client::DEFAULT_GRPC_MESSAGE_SIZE;
 use databend_common_meta_client::MetaGrpcClient;
 use databend_common_meta_client::errors::CreationError;
 use databend_common_meta_control::admin::MetaAdminClient;
@@ -89,6 +90,7 @@ impl App {
             None,
             None,
             None,
+            DEFAULT_GRPC_MESSAGE_SIZE,
         )?;
 
         let res = client.get_cluster_status().await?;
@@ -171,6 +173,7 @@ impl App {
                 None,
                 None,
                 None,
+                DEFAULT_GRPC_MESSAGE_SIZE,
             )?;
             let res = client.get_kv("foo").await;
             println!("{}-th: get_kv(foo): {:?}", i, res);

src/meta/binaries/metactl/main.rs

@@ -27,6 +27,7 @@ use anyhow::Result;
 use anyhow::bail;
 use clap::Parser;
 use databend_common_meta_client::ClientHandle;
+use databend_common_meta_client::DEFAULT_GRPC_MESSAGE_SIZE;
 use databend_common_meta_client::MetaGrpcClient;
 use databend_common_meta_runtime_api::SpawnApi;
 use databend_common_meta_types::MatchSeq;
@@ -136,6 +137,7 @@ async fn main() -> Result<()> {
                     None,
                     None,
                     None,
+                    DEFAULT_GRPC_MESSAGE_SIZE,
                 );
 
                 let client = match client {

src/meta/binaries/metaverifier/main.rs

@@ -133,6 +133,11 @@ pub struct Config {
     #[clap(long, default_value = "")]
     pub grpc_tls_server_key: String,
 
+    /// Maximum message size for MetaService gRPC communication (in bytes).
+    /// Default: 32MB (33554432).
+    #[clap(long)]
+    pub grpc_api_max_message_size: Option<usize>,
+
     #[clap(flatten)]
     pub raft_config: RaftConfig,
 }
@@ -218,6 +223,7 @@ impl TryFrom<Config> for MetaConfig {
                         cert: outer.grpc_tls_server_cert,
                         key: outer.grpc_tls_server_key,
                     },
+                    max_message_size: outer.grpc_api_max_message_size,
                 },
                 raft_config: outer.raft_config.into(),
             },
@@ -246,6 +252,7 @@ impl From<MetaConfig> for Config {
             grpc_api_advertise_host: inner.service.grpc.advertise_host,
             grpc_tls_server_cert: inner.service.grpc.tls.cert,
             grpc_tls_server_key: inner.service.grpc.tls.key,
+            grpc_api_max_message_size: inner.service.grpc.max_message_size,
             raft_config: inner.service.raft_config.into(),
         }
     }
@@ -444,6 +451,11 @@ pub struct RaftConfig {
     /// Max timeout(in milliseconds) when waiting a cluster leader.
     #[clap(long, default_value = "180000")]
     pub wait_leader_timeout: u64,
+
+    /// Maximum message size for Raft gRPC communication (in bytes).
+    /// Default: 32MB (33554432).
+    #[clap(long)]
+    pub raft_grpc_max_message_size: Option<usize>,
 }
 
 // TODO(rotbl): should not be used.
@@ -487,6 +499,7 @@ impl From<RaftConfig> for InnerRaftConfig {
             id: x.id,
             cluster_name: x.cluster_name,
             wait_leader_timeout: x.wait_leader_timeout,
+            raft_grpc_max_message_size: x.raft_grpc_max_message_size,
         }
     }
 }
@@ -524,6 +537,7 @@ impl From<InnerRaftConfig> for RaftConfig {
             id: inner.id,
             cluster_name: inner.cluster_name,
             wait_leader_timeout: inner.wait_leader_timeout,
+            raft_grpc_max_message_size: inner.raft_grpc_max_message_size,
         }
     }
 }

src/meta/cli-config/src/lib.rs

@@ -19,6 +19,7 @@ use std::net::SocketAddr;
 use std::net::ToSocketAddrs;
 
 use anyhow::anyhow;
+use databend_common_meta_client::DEFAULT_GRPC_MESSAGE_SIZE;
 use databend_common_meta_client::MetaGrpcClient;
 use databend_common_meta_client::required;
 use databend_common_meta_raft_store::key_spaces::RaftStoreEntry;
@@ -82,6 +83,7 @@ pub async fn export_from_grpc(
         None,
         None,
         required::export(),
+        DEFAULT_GRPC_MESSAGE_SIZE,
     )?;
 
     let mut grpc_client = client.make_established_client().await?;

src/meta/control/src/export_from_grpc.rs

@@ -17,6 +17,7 @@ use std::net::SocketAddr;
 use std::net::ToSocketAddrs;
 
 use anyhow::anyhow;
+use databend_common_meta_client::DEFAULT_GRPC_MESSAGE_SIZE;
 use databend_common_meta_client::MetaGrpcClient;
 use databend_common_meta_types::protobuf;
 use databend_meta_runtime::DatabendRuntime;
@@ -75,6 +76,7 @@ pub async fn keys_layout_from_grpc(
         None,
         None,
         None,
+        DEFAULT_GRPC_MESSAGE_SIZE,
     )?;
 
     let mut grpc_client = client.make_established_client().await?;