Skip to content

fix: Don't invoke logging in heavy IO loop #18269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: Don't invoke logging in heavy IO loop #18269

wants to merge 2 commits into from

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 29, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This PR introduce a upstream PR: apache/opendal#6343

By this PR, we can avoid invoking logging in heavy IO loop

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jun 29, 2025
@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label Jun 29, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18269-7d1fadc-1751183402

note: this image tag is only available for internal use.

@BohuTANG
Copy link
Member

BohuTANG commented Jun 29, 2025 •
edited
Loading

Now(There is no fasttrace stack):
image
Waiting the OpenDAL new release 👍

@BohuTANG BohuTANG marked this pull request as draft June 29, 2025 09:30
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 29, 2025

Waiting the OpenDAL new release 👍

OpenDAL's new release will include some breaking changes. I suggest we merge this PR as is and let me bump the new opendal release in the future.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 12, 2025

We can bump opendal directly now

@Xuanwo Xuanwo closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Xuanwo @BohuTANG