Skip to content

Commit 72189f9

Browse files
authored
Merge pull request #215 from rkvst/mmwilder26/jpn_updatingcomments
Updating comments to reflect updated environment variables
2 parents 12d1fec + 3eb25c6 commit 72189f9

File tree

3 files changed

+17
-18
lines changed

3 files changed

+17
-18
lines changed

archivist/notebooks/Create Asset and Events.ipynb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,12 @@
6666
"metadata": {},
6767
"outputs": [],
6868
"source": [
69-
"# URL, CLIENT, SECRET are environment variables that represent connection parameters.\n",
69+
"# RKVST_URL, RKVST_APPREG_CLIENT, RKVST_APPREG_SECRET are environment variables that represent connection parameters.\n",
7070
"#\n",
71-
"# URL = represents the url to the RKVST application\n",
72-
"# CLIENT = represents the client ID from an Application Registration\n",
73-
"# SECRET = represents the client secret from an Application Registration\n",
71+
"# RKVST_URL = represents the url to the RKVST application\n",
72+
"# RKVST_APPREG_CLIENT = represents the client ID from an Application Registration\n",
73+
"# RKVST_APPREG_SECRET = represents the client secret from an Application Registration\n",
74+
"# RKVST_UNIQUE_ID = is an environment variable that is a unique identifier\n",
7475
"RKVST_URL = getenv(\"RKVST_URL\")\n",
7576
"RKVST_APPREG_CLIENT = getenv(\"RKVST_APPREG_CLIENT\")\n",
7677
"RKVST_APPREG_SECRET = getenv(\"RKVST_APPREG_SECRET\")\n",
@@ -215,7 +216,6 @@
215216
],
216217
"source": [
217218
"# Creating an Asset for musical artist Adele\n",
218-
"# Use the above value for artistid\n",
219219
"print(\"Creating Asset\")\n",
220220
"asset = create_artist(\n",
221221
" arch,\n",

archivist/notebooks/Find Asset and Create Attachment.ipynb

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
"# Main function, establishes a connection to RKVST using an App Registration then uses that\n",
2121
"# to find existing Asset and create an attachment.\n",
2222
"#\n",
23-
"# The attachment is an image located in a folder named \"test_files\"\n",
24-
"#\n",
2523
"# Note: The purpose of RKVST Jupyter Notebooks is to provide simplified examples that one can easily execute and digest.\n",
2624
"# The RKVST Python SDK is authored to work cleanly with more advanced coding techniques.\n",
2725
"#\n",
@@ -65,11 +63,13 @@
6563
"metadata": {},
6664
"outputs": [],
6765
"source": [
68-
"# URL, CLIENT, SECRET are environment variables that represent connection parameters.\n",
66+
"# RKVST_URL, RKVST_APPREG_CLIENT, RKVST_APPREG_SECRET are environment variables that represent connection parameters.\n",
6967
"#\n",
70-
"# URL = represents the url to the RKVST application\n",
71-
"# CLIENT = represents the client ID from an Application Registration\n",
72-
"# SECRET = represents the client secret from an Application Registration\n",
68+
"# RKVST_URL = represents the url to the RKVST application\n",
69+
"# RKVST_APPREG_CLIENT = represents the client ID from an Application Registration\n",
70+
"# RKVST_APPREG_SECRET = represents the client secret from an Application Registration\n",
71+
"# RKVST_UNIQUE_ID = is an environment variable that is a unique identifier\n",
72+
"# RKVST_ARTIST_ATTACHMENT = represents the location of the attachment\n",
7373
"RKVST_URL = getenv(\"RKVST_URL\")\n",
7474
"RKVST_APPREG_CLIENT = getenv(\"RKVST_APPREG_CLIENT\")\n",
7575
"RKVST_APPREG_SECRET = getenv(\"RKVST_APPREG_SECRET\")\n",
@@ -243,7 +243,6 @@
243243
],
244244
"source": [
245245
"# Finding existing artist by name and artist id\n",
246-
"# Fill in the artistid from Create Asset and Events notebook\n",
247246
"print(\"Finding Asset\")\n",
248247
"asset = get_artist(arch, \"Adele Laurie Blue Adkins\", RKVST_UNIQUE_ID)\n",
249248
"print(\"Asset\", json_dumps(asset, indent=4))"

archivist/notebooks/Find Asset and Event Creation.ipynb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,12 @@
6363
"metadata": {},
6464
"outputs": [],
6565
"source": [
66-
"# URL, CLIENT, SECRET are environment variables that represent connection parameters.\n",
66+
"# RKVST_URL, RKVST_APPREG_CLIENT, RKVST_APPREG_SECRET are environment variables that represent connection parameters.\n",
6767
"#\n",
68-
"# URL = represents the url to the RKVST application\n",
69-
"# CLIENT = represents the client ID from an Application Registration\n",
70-
"# SECRET = represents the client secret from an Application Registration\n",
68+
"# RKVST_URL = represents the url to the RKVST application\n",
69+
"# RKVST_APPREG_CLIENT = represents the client ID from an Application Registration\n",
70+
"# RKVST_APPREG_SECRET = represents the client secret from an Application Registration\n",
71+
"# RKVST_UNIQUE_ID = is an environment variable that is a unique identifier\n",
7172
"RKVST_URL = getenv(\"RKVST_URL\")\n",
7273
"RKVST_APPREG_CLIENT = getenv(\"RKVST_APPREG_CLIENT\")\n",
7374
"RKVST_APPREG_SECRET = getenv(\"RKVST_APPREG_SECRET\")\n",
@@ -216,7 +217,6 @@
216217
],
217218
"source": [
218219
"# Finding existing artist by name and artist id\n",
219-
"# Fill in the artistid from Create Asset and Events notebook\n",
220220
"print(\"Finding Asset\")\n",
221221
"asset = get_artist(arch, \"Adele Laurie Blue Adkins\", RKVST_UNIQUE_ID)\n",
222222
"print(\"Asset\", json_dumps(asset, indent=4))"
@@ -338,7 +338,7 @@
338338
"name": "python",
339339
"nbconvert_exporter": "python",
340340
"pygments_lexer": "ipython3",
341-
"version": "3.8.15"
341+
"version": "3.9.5 (v3.9.5:0a7dcbdb13, May 3 2021, 13:17:02) \n[Clang 6.0 (clang-600.0.57)]"
342342
},
343343
"vscode": {
344344
"interpreter": {

0 commit comments

Comments
 (0)