Skip to content

Comment of return value of 'OnItemClickListener.onItemClick()' may mislead. #762

@tankpow

Description

@tankpow

Return value of 'OnItemClickListener.onItemClick()' is commented as:

  • @return true if the click should activate the itemView according to the selection mode,
  • false for no change to the itemView.

But 'OnItemClickListener.onItemClick()' is only used in 'FlexibleViewHolder.onClick()', which uses this return value to determine whether to toggle activation.

Is is proper to change comment to something like "return true if the click should toggle activation of itemView"?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions