skip type checking deprecation_date on the basis of jsonschemas (#11823)

* skip type checking deprecation_date on the basis of jsonschemas

* update test

Author: MichelleArk

core/dbt/jsonschemas.py

@@ -120,8 +120,8 @@ def jsonschema_validate(schema: Dict[str, Any], json: Dict[str, Any], file_path:
                             file=file_path,
                             key_path=key_path,
                         )
-        elif error.validator == "type" and "deprecation_date" not in error_path:
-            # Not deprecating invalid types yet, except for pre-existing deprecation_date deprecation
+        elif error.validator == "type":
+            # Not deprecating invalid types yet
             pass
         elif error.validator == "anyOf" and len(error_path) > 0 and error_path[-1] == "config":
             for sub_error in error.context or []:

tests/functional/deprecations/test_deprecations.py

@@ -10,9 +10,6 @@
 from dbt import deprecations
 from dbt.cli.main import dbtRunner
 from dbt.clients.registry import _get_cached
-from dbt.deprecations import (
-    GenericJSONSchemaValidationDeprecation as GenericJSONSchemaValidationDeprecationCore,
-)
 from dbt.events.types import (
     CustomKeyInConfigDeprecation,
     CustomKeyInObjectDeprecation,
@@ -321,16 +318,9 @@ def test_deprecated_invalid_deprecation_date(self, project):
                 True
             ), "Expected an exception to be raised, because a model object can't be created with a deprecation_date as an int"
 
-        if GenericJSONSchemaValidationDeprecationCore()._is_preview:
-            assert len(note_catcher.caught_events) == 1
-            assert len(event_catcher.caught_events) == 0
-            event = note_catcher.caught_events[0]
-        else:
-            assert len(event_catcher.caught_events) == 1
-            assert len(note_catcher.caught_events) == 0
-            event = event_catcher.caught_events[0]
-
-        assert "1 is not of type 'string', 'null' in file" in event.info.msg
+        # type-based jsonschema validation is not enabled, so no deprecations are raised even though deprecation_date is an int
+        assert len(event_catcher.caught_events) == 0
+        assert len(note_catcher.caught_events) == 0
 
 
 class TestDuplicateYAMLKeysInSchemaFiles: