Make modules.re methods accept an already compiled pattern

Author: fornwall

.changes/unreleased/Fixes-20250824-234019.yaml

@@ -0,0 +1,3 @@
+kind: Fixes
+body: Make modules.re methods accept an already compiled pattern
+time: 2025-08-24T23:40:19.408475+02:00

crates/dbt-jinja/minijinja-contrib/Cargo.toml

@@ -1,15 +1,15 @@
 [package]
 name = "minijinja-contrib"
 version = "2.5.0"
-edition = "2021"
+edition = "2024"
 license = "Apache-2.0"
 authors = ["Armin Ronacher <[email protected]>"]
 description = "Extra utilities for MiniJinja"
 homepage = "https://github.com/mitsuhiko/minijinja"
 repository = "https://github.com/mitsuhiko/minijinja"
 keywords = ["jinja", "jinja2", "templates"]
 readme = "README.md"
-rust-version = "1.70"
+rust-version = "1.85.0"
 
 [package.metadata.docs.rs]
 rustdoc-args = ["--cfg", "docsrs", "--html-in-header", "doc-header.html"]

crates/dbt-jinja/minijinja-contrib/src/modules/re.rs

@@ -295,13 +295,19 @@ fn get_or_compile_regex_and_text(args: &[Value]) -> Result<(Box<Regex>, &str), E
     }
 
     // First arg: either compiled or raw pattern
-    let pattern = args[0].to_string();
-    let compiled = Box::new(Regex::new(&pattern).map_err(|e| {
-        Error::new(
-            ErrorKind::InvalidOperation,
-            format!("Failed to compile regex: {e}"),
-        )
-    })?);
+    let compiled = if let Some(object) = args[0].as_object()
+        && let Some(pattern) = object.downcast_ref::<Pattern>()
+    {
+        Box::new(pattern._compiled.clone())
+    } else {
+        let pattern = args[0].to_string();
+        Box::new(Regex::new(&pattern).map_err(|e| {
+            Error::new(
+                ErrorKind::InvalidOperation,
+                format!("Failed to compile regex: {e}"),
+            )
+        })?)
+    };
 
     // Second arg: the text to match against
     let text = args[1].to_string();
@@ -413,4 +419,18 @@ mod tests {
         .unwrap();
         assert!(!result.is_true());
     }
+
+    #[test]
+    fn test_re_search() {
+        let result = re_search(&[
+            Value::from(".*".to_string()),
+            Value::from("xyz".to_string()),
+        ])
+        .unwrap();
+        assert!(result.is_true());
+
+        let compiled_pattern = re_compile(&[Value::from(".*".to_string())]).unwrap();
+        let result = re_search(&[compiled_pattern, Value::from("xyz".to_string())]).unwrap();
+        assert!(result.is_true());
+    }
 }