Skip to content

Commit 86e5142

Browse files
committed
Add write_default to new fields
1 parent 3410293 commit 86e5142

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

crates/iceberg/src/transaction/update_schema.rs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,9 @@ impl UpdateSchemaAction {
114114
initial_default: Literal,
115115
) -> Self {
116116
self.add_field(Arc::new(
117-
NestedField::required(0, name, field_type).with_initial_default(initial_default),
117+
NestedField::required(0, name, field_type)
118+
.with_initial_default(initial_default.clone())
119+
.with_write_default(initial_default),
118120
))
119121
}
120122

@@ -132,7 +134,8 @@ impl UpdateSchemaAction {
132134
) -> Self {
133135
self.add_field(Arc::new(
134136
NestedField::required(0, name, field_type)
135-
.with_initial_default(initial_default)
137+
.with_initial_default(initial_default.clone())
138+
.with_write_default(initial_default)
136139
.with_doc(doc),
137140
))
138141
}
@@ -192,7 +195,9 @@ impl UpdateSchemaAction {
192195
self.add_field_to(
193196
parent,
194197
Arc::new(
195-
NestedField::required(0, name, field_type).with_initial_default(initial_default),
198+
NestedField::required(0, name, field_type)
199+
.with_initial_default(initial_default.clone())
200+
.with_write_default(initial_default),
196201
),
197202
)
198203
}
@@ -213,7 +218,8 @@ impl UpdateSchemaAction {
213218
parent,
214219
Arc::new(
215220
NestedField::required(0, name, field_type)
216-
.with_initial_default(initial_default)
221+
.with_initial_default(initial_default.clone())
222+
.with_write_default(initial_default)
217223
.with_doc(doc),
218224
),
219225
)
@@ -781,6 +787,7 @@ mod tests {
781787
assert_eq!(field.id, 4);
782788
assert!(field.required);
783789
assert_eq!(field.initial_default, Some(Literal::int(0)));
790+
assert_eq!(field.write_default, Some(Literal::int(0)));
784791
}
785792

786793
#[tokio::test]

0 commit comments

Comments
 (0)