Add subgraph generator for metrics #1802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
approved these changes
Jul 31, 2025
plypaul
changed the title
plypaul
force-pushed
the
p/semantic_graph__50
branch
from
b397361 to
f85dd9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subgraph generator to model the relationship between metrics. There are a few special cases related to labeling the edges between metrics and their inputs. Normally, the group-by items available for a metric are an intersection of the available group-by items of the input metrics or input measures. However, there are a few special cases (e.g. cumulative metrics) that are more restrictive than this general rule. These labels will be later used to limit graph traversal.