Merge branch 'release'

Author: perdrix52

DeepSkyStacker/FrameList.cpp

@@ -196,7 +196,9 @@ namespace DSS
 		{
 			for (auto it = group.pictures->cbegin(); it != group.pictures->cend(); ++it)
 			{
-				if (it->IsLightFrame() && it->m_bChecked == Qt::Checked && it->m_bUseAsStarting)
+				if (it->IsLightFrame() && 
+					it->m_bUseAsStarting
+					)
 				{
 					return QString::fromStdU16String(it->filePath.generic_u16string());
 				}

DeepSkyStacker/RegisterSettings.cpp

@@ -118,6 +118,7 @@ void RegisterSettings::onInitDialog()
 	ui->luminanceThreshold->
 		setSliderPosition(value);
 	ui->luminancePercent->setText(QString("%1%").arg(value));
+	detectionThreshold = value;
 
 	ui->medianFilter->
 		setChecked(workspace->value("Register/ApplyMedianFilter", false).toBool());

DeepSkyStacker/StackingEngine.cpp

@@ -455,7 +455,11 @@ bool CStackingEngine::AddLightFramesToList(CAllStackingTasks& tasks)
 					lfi = bitmap;
 					lfi.RefreshSuperPixel();
 
-					if (!m_strReferenceFrame.CompareNoCase(lfi.filePath.c_str()))
+					//
+					// m_strReferenceFrame is a CString but contains the reference frame path
+					// with / separators rather than \\
+					//
+					if (!m_strReferenceFrame.CompareNoCase(lfi.filePath.generic_wstring().c_str()))
 					{
 						lfi.m_bStartingFrame = true;
 						bReferenceFrameFound = true;
@@ -819,7 +823,7 @@ void CStackingEngine::ComputeOffsets()
 
 	const int lLast = static_cast<int>(m_vBitmaps.size() * m_fKeptPercentage / 100.0);
 	if (m_pProgress)
-		m_pProgress->Start1(strText, lLast, false);
+		m_pProgress->Start1(strText, lLast, true);
 
 	// The first bitmap is the best one
 	if (m_vBitmaps.size() > 1)

Installers/README.txt

@@ -3,70 +3,51 @@ Welcome to DeepSkyStacker 5.1.4
 
 Only 64 bit versions of Windows 10 and later are supported in this release.
 
-Changes since the last release:
+This is a bug fix release for problems reported against 5.1.0, 5.1.1, 5.1.2
 
-1. Upgrade CFISTIO library to 4.2.0
-
-2. Always create a tracefile in DeepSkyStacker sub-folder of the user's Documents folder.  The file will be called e.g.
-
-	DSSTrace_yyyy-mm-ddThh-hh-ssZ.log where the timestamp is GMT time.
-
-The trace file will be deleted on normal application exit, but an option is provided to keep the file.
-
-Welcome to DeepSkyStacker 5.1.3
-===============================
-
-Changes since the last release:
-
-1. Bug fix - correct problems with drag drop of a directory.
-
-2. Enhancement - if Custom Rectangle mode is read from a filelist or settings file, switch to Intersection mode.
-
-3. Bug fix - correct handling of reference frame in filelist.
+1. Possible bug fix - DeepSkyStacker terminated at startup when running on ARM version of Windows 11 in x64 emulation mode.  Unable to test.
 
-4. Bug Fix - FITS/DDP choice of Camera was not being handled correctly.
+2. Bug fix - A corrupt info.txt file caused an infinite loop.
 
-Welcome to DeepSkyStacker 5.1.2
-===============================
+3. Diagnostic added - Report processor architecture and processor type in trace file and to stderr at startup.
 
-This is a bug fix release for problems reported against 5.1.0 and 5.1.1
+4. Bug fix - Stacked FITS images in SuperPixel mode were displayed only in the top left corner.
 
-1. Bug fix - correct handling of file types (TIFF/FITS) in DeepSkyStackerCL for intermediate and final files
+5. Bug fix - Resolve occasional odd problems when using edit stars mode.
 
-2. Bug fix - correct handling of Stacking Mode (Standard/Mosaic/Intersection/Custom)
+6. Bug fix - DeepSkyStackerCL was only displaying the help text regardless of command line input.
 
-3. Bug fix - unable to select a custom rectangle immediately after opening image file
+7. Enhancement - Reinstate Image Properties as a Qt based dialogue to allow changing e.g. exposure for multiple images at once
 
-4. Bug fix - fileids in filelist files were being incorrectly written as ANSI not UTF8
+8. Bug fix - Fields in the image list and the group tabs were not updated when switching to another language.
 
-5. Bug fix - the selection for a custom rectangle was not always visible
+9. Bug fix - remove all "Set Black Point to Zero" recommendations from "Recommended Settings"
 
-6. Enhancement - reduce the minium size for the image list to be two rows
+10. Bug fix - Invalid input in RAW/DDP settings for scale factors caused an assertion failure
 
-Welcome to DeepSkyStacker 5.1.1
-===============================
+11. Bug fix - correct handling of file types (TIFF/FITS) in DeepSkyStackerCL for intermediate and final files
 
-This is a bug fix release for problems reported against 5.1.0
+12. Bug fix - correct handling of Stacking Mode (Standard/Mosaic/Intersection/Custom)
 
-1. Possible bug fix - DeepSkyStacker terminated at startup when running on ARM version of Windows 11 in x64 emulation mode.  Unable to test.
+13. Bug fix - unable to select a custom rectangle immediately after opening image file
 
-2. Bug fix - A corrupt info.txt file caused an infinite loop.
+14. Bug fix - fileids in filelist files were being incorrectly written as ANSI not UTF8
 
-3. Diagnostic added - Report processor architecture and processor type in trace file and to stderr at startup.
+15. Bug fix - the selection for a custom rectangle was not always visible
 
-4. Bug fix - Stacked FITS images in SuperPixel mode were displayed only in the top left corner.
+16. Enhancement - reduce the minimum size for the image list to be two rows
 
-5. Bug fix - Resolve occasional odd problems when using edit stars mode.
+17. Bug fix - correct problems with drag drop of a directory.
 
-6. Bug fix - DeepSkyStackerCL was only displaying the help text regardless of command line input.
+18. Enhancement - if Custom Rectangle mode is read from a filelist or settings file, switch to Intersection mode.
 
-7. Enhancement - Reinstate Image Properties as a Qt based dialogue to allow changing e.g. exposure for multiple images at once
+19. Bug fix - correct handling of reference frame in filelist.
 
-8. Bug fix - Fields in the image list and the group tabs were not updated when switching to another language.
+20. Bug Fix - FITS/DDP choice of Camera was not being handled correctly.
 
-9. Bug fix - remove all "Set Black Point to Zero" recommendations from "Recommended Settings"
+21. Bug fix - ensure that reference frame is used a) when checked, and b) when not checked
 
-10. Bug fix - Invalid input in RAW/DDP settings for scale factors caused an assertion failure
+22. Bug fix - Register settings set a value of 0 for the luminance threshold when it was initially set to 20.
 
 Welcome to DeepSkyStacker 5.1.0
 ===============================