Add the ComparatorConfig parameter (doctrine#7067)

|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | Follows doctrine#6300

#### Summary

This PR materializes the previously virtual `ComparatorConfig` parameter
in `AbstractSchemaManager::createComparator()`.

Author: derrabus

src/Schema/AbstractSchemaManager.php

@@ -29,8 +29,6 @@
 use function array_values;
 use function assert;
 use function count;
-use function func_get_arg;
-use function func_num_args;
 use function strtolower;
 
 /**
@@ -1204,9 +1202,9 @@ private function getDatabase(string $methodName): string
         return $database;
     }
 
-    public function createComparator(/* ComparatorConfig $config = new ComparatorConfig() */): Comparator
+    public function createComparator(ComparatorConfig $config = new ComparatorConfig()): Comparator
     {
-        return new Comparator($this->platform, func_num_args() > 0 ? func_get_arg(0) : new ComparatorConfig());
+        return new Comparator($this->platform, $config);
     }
 
     /**

src/Schema/MySQLSchemaManager.php

@@ -21,8 +21,6 @@
 use function array_map;
 use function assert;
 use function explode;
-use function func_get_arg;
-use function func_num_args;
 use function implode;
 use function preg_match;
 use function preg_match_all;
@@ -275,7 +273,7 @@ protected function _getPortableTableForeignKeysList(array $rows): array
     }
 
     /** @throws Exception */
-    public function createComparator(/* ComparatorConfig $config = new ComparatorConfig() */): Comparator
+    public function createComparator(ComparatorConfig $config = new ComparatorConfig()): Comparator
     {
         return new MySQL\Comparator(
             $this->platform,
@@ -286,7 +284,7 @@ public function createComparator(/* ComparatorConfig $config = new ComparatorCon
                 new ConnectionCollationMetadataProvider($this->connection),
             ),
             $this->getDefaultTableOptions(),
-            func_num_args() > 0 ? func_get_arg(0) : new ComparatorConfig(),
+            $config,
         );
     }
 

src/Schema/SQLServerSchemaManager.php

@@ -12,8 +12,6 @@
 use Doctrine\DBAL\Schema\Name\OptionallyQualifiedName;
 
 use function assert;
-use function func_get_arg;
-use function func_num_args;
 use function implode;
 use function is_string;
 use function preg_match;
@@ -220,12 +218,12 @@ protected function _getPortableViewDefinition(array $view): View
     }
 
     /** @throws Exception */
-    public function createComparator(/* ComparatorConfig $config = new ComparatorConfig() */): Comparator
+    public function createComparator(ComparatorConfig $config = new ComparatorConfig()): Comparator
     {
         return new SQLServer\Comparator(
             $this->platform,
             $this->getDatabaseCollation(),
-            func_num_args() > 0 ? func_get_arg(0) : new ComparatorConfig(),
+            $config,
         );
     }
 

src/Schema/SQLiteSchemaManager.php

@@ -19,8 +19,6 @@
 use function array_merge;
 use function assert;
 use function count;
-use function func_get_arg;
-use function func_num_args;
 use function implode;
 use function is_string;
 use function preg_match;
@@ -334,9 +332,9 @@ private function parseOptionallyQuotedName(string $sql): string
         return $sql;
     }
 
-    public function createComparator(/* ComparatorConfig $config = new ComparatorConfig() */): Comparator
+    public function createComparator(ComparatorConfig $config = new ComparatorConfig()): Comparator
     {
-        return new SQLite\Comparator($this->platform, func_num_args() > 0 ? func_get_arg(0) : new ComparatorConfig());
+        return new SQLite\Comparator($this->platform, $config);
     }
 
     protected function selectTableNames(string $databaseName): Result