Allow obstore.store input into tiff class (#53)

* Allow obstore.store input to store method

* Allow obstore type check

Author: kylebarron

python/Cargo.toml

@@ -23,7 +23,7 @@ object_store = "0.12"
 pyo3 = { version = "0.23.0", features = ["macros"] }
 pyo3-async-runtimes = "0.23"
 pyo3-bytes = "0.1.3"
-pyo3-object_store = "0.1.0-beta.2"
+pyo3-object_store = "0.1.0-beta.4"
 rayon = "1.10.0"
 tokio-rayon = "2.1.0"
 thiserror = "1"

python/pyproject.toml

@@ -31,6 +31,7 @@ dev-dependencies = [
     "mkdocstrings-python>=1.13.0",
     "mkdocstrings>=0.27.0",
     "numpy>=1",
+    "obstore",
     "pip>=24.2",
     "pytest-asyncio>=0.24.0",
     "pytest>=8.3.3",

python/python/async_tiff/_tiff.pyi

@@ -1,11 +1,16 @@
+import obstore
 from ._tile import Tile
 from ._ifd import ImageFileDirectory
 from .store import ObjectStore
 
 class TIFF:
     @classmethod
     async def open(
-        cls, path: str, *, store: ObjectStore, prefetch: int | None = 16384
+        cls,
+        path: str,
+        *,
+        store: obstore.store.ObjectStore | ObjectStore,
+        prefetch: int | None = 16384,
     ) -> TIFF: ...
     @property
     def ifds(self) -> list[ImageFileDirectory]: ...

python/src/lib.rs

@@ -54,8 +54,8 @@ fn _async_tiff(py: Python, m: &Bound<PyModule>) -> PyResult<()> {
     m.add_class::<PyThreadPool>()?;
     m.add_class::<PyTIFF>()?;
 
-    pyo3_object_store::register_store_module(py, m, "async_tiff")?;
-    pyo3_object_store::register_exceptions_module(py, m, "async_tiff")?;
+    pyo3_object_store::register_store_module(py, m, "async_tiff", "store")?;
+    pyo3_object_store::register_exceptions_module(py, m, "async_tiff", "exceptions")?;
 
     Ok(())
 }

python/src/tiff.rs

@@ -6,7 +6,7 @@ use pyo3::exceptions::PyIndexError;
 use pyo3::prelude::*;
 use pyo3::types::PyType;
 use pyo3_async_runtimes::tokio::future_into_py;
-use pyo3_object_store::PyObjectStore;
+use pyo3_object_store::AnyObjectStore;
 
 use crate::tile::PyTile;
 use crate::PyImageFileDirectory;
@@ -25,10 +25,10 @@ impl PyTIFF {
         _cls: &'py Bound<PyType>,
         py: Python<'py>,
         path: String,
-        store: PyObjectStore,
+        store: AnyObjectStore,
         prefetch: Option<u64>,
     ) -> PyResult<Bound<'py, PyAny>> {
-        let reader = ObjectReader::new(store.into_inner(), path.into());
+        let reader = ObjectReader::new(store.into_dyn(), path.into());
         let object_reader = reader.clone();
 
         let cog_reader = future_into_py(py, async move {