Minor cleanup and fixes suggested by coderabbitai

Author: rlskoeser

CHANGELOG.md

@@ -19,7 +19,6 @@
 - Dropped support for Python 3.9
 - Reorganized examples folder to avoid unnecessary nesting
   - ISMI data has been updated from older JSON data to examples in RDF (turtle)
-  -
 
 
 ## 0.3.1

README.md

@@ -11,7 +11,7 @@ portions of EDTF (Extended Date Time Format), and parsing and conversion for dat
 
 *Undate was initially created as part of a [DH-Tech](https://dh-tech.github.io/) hackathon in November 2022.*
 
----
+* * * 
 
 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.11068867.svg)](https://doi.org/10.5281/zenodo.11068867)
 [![License](https://img.shields.io/badge/License-Apache_2.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)

src/undate/interval.py

@@ -94,7 +94,9 @@ def duration(self) -> Timedelta:
 
         # if range is open-ended, can't calculate
         if self.earliest is None or self.latest is None:
-            return NotImplemented
+            raise NotImplementedError(
+                "Cannot calculate duration for open-ended interval"
+            )
 
         # if both years are known, subtract end of range from beginning of start
         if self.latest.known_year and self.earliest.known_year:

src/undate/undate.py

@@ -198,8 +198,8 @@ def set_calendar(self, calendar: Union[str, Calendar]):
                 # look for calendar by upper-case name
                 try:
                     calendar = Calendar[calendar.upper()]
-                except KeyError:
-                    raise ValueError(f"Calendar `{calendar}` is not supported")
+                except KeyError as err:
+                    raise ValueError(f"Calendar `{calendar}` is not supported") from err
             self.calendar = calendar
 
     def __str__(self) -> str:
@@ -292,15 +292,13 @@ def __eq__(self, other: object) -> bool:
         # in one format (i.e. X for missing digits).
         # If we support other formats, will need to normalize to common
         # internal format for comparison
-        if looks_equal:
+        if looks_equal and (
             # if any part of either date that is known is _partially_ known,
             # then these dates are not equal
-            if any(
-                [self.is_partially_known(p) for p in self.initial_values.keys()]
-            ) or any(
-                [other.is_partially_known(p) for p in other.initial_values.keys()]
-            ):
-                return False
+            any([self.is_partially_known(p) for p in self.initial_values.keys()])
+            or any([other.is_partially_known(p) for p in other.initial_values.keys()])
+        ):
+            return False
 
         return looks_equal
 

tests/test_converters/test_calendars/test_islamic/test_islamic_parser.py

@@ -1,4 +1,6 @@
 import pytest
+from lark.exceptions import LarkError
+
 from undate.converters.calendars.islamic.parser import islamic_parser
 
 
@@ -72,5 +74,5 @@ def test_should_parse(date_string):
 
 @pytest.mark.parametrize("date_string", error_cases)
 def test_should_error(date_string):
-    with pytest.raises(Exception):
+    with pytest.raises(LarkError):
         islamic_parser.parse(date_string)

tests/test_interval.py

@@ -144,7 +144,10 @@ def test_duration(self):
         assert jan_march_duration.days == 2
 
         # duration is not supported for open-ended intervals
-        assert UndateInterval(Undate(2000), None).duration() == NotImplemented
+        with pytest.raises(
+            NotImplementedError, match="Cannot calculate.*open-ended interval"
+        ):
+            assert UndateInterval(Undate(2000), None).duration()
 
         # one year set and the other not currently raises not implemented error
         with pytest.raises(NotImplementedError):