Stash vector out of bounds from spurious loop?

[hateborne]

(Hitting vector out of bounds issue with underflow itemId, which is what started all of this.)

Why is the InvDrawSlotBack call handled in a separate loop (stash.cpp:355) instead of the loop right below it (stash.cpp:363)? The validation seems to be handled in the second loop and the first loop seems (from a relative outsider) problematic.

Example of lines 355 - 381:

	for (auto slot : StashGridRange) {
		StashStruct::StashCell itemId = Stash.GetItemIdAtPosition(slot);
		if (itemId == StashStruct::EmptyCell) {
			continue; // No item in the given slot
		}

		Item &item = Stash.stashList[itemId];

		if (Stash.IsItemAtPosition(slot)) {
			InvDrawSlotBack(out, GetStashSlotCoord(slot) + offset, InventorySlotSizeInPixels, item._iMagical);
		}

		if (item.position != slot) {
			continue; // Not the first slot of the item
		}

		int frame = item._iCurs + CURSOR_FIRSTITEM;

		const Point position = GetStashSlotCoord(item.position) + offset;
		const ClxSprite sprite = GetInvItemSprite(frame);

		if (pcursstashitem == itemId) {
			uint8_t color = GetOutlineColor(item, true);
			ClxDrawOutline(out, color, position, sprite);
		}

		DrawItem(item, out, position, sprite);
	}

[StephenCWills]

FYI, it would have been more appropriate to create an issue and follow the bug report template rather than creating a discussion. I'm creating a new issue from this discussion and will include a proper response there.

[hateborne]

Fair enough, I was trying to avoid pestering unnecessary and a discussion seemed (at the time) like a slightly less noisy way to go about it.

Thank you!