Skip to content

Refactor and align Accessibility PR for maintainability and merge readiness #8439

@AJenbo

Description

@AJenbo

Feature Type

Refactor #8438

Describe

Description

A large accessibility-focused PR has been submitted (≈ +7,145 / −1,307 LOC) that introduces many valuable features. However, the current implementation does not align well with DevilutionX standards and is not in a mergeable state.

This issue tracks the work required to refactor, split, and align the changes so they can be reviewed and merged incrementally.

The goal is not to redesign the features, but to:

  • Integrate them cleanly into existing systems
  • Reduce diff size
  • Improve maintainability and reviewability
  • Split unrelated changes into focused PRs

Summary of Problems

  • Extremely large diff for a single feature area
  • Accessibility logic mixed across many unrelated systems
  • Assets added outside the standard SFX pipeline
  • Audio duplicated across formats (ogg/mp3/wav)
  • Translation updates bundled with feature work
  • README rebranding and keybind documentation mixed with code changes
  • New systems (e.g. SoundPool) overlapping with existing audio abstractions

Sub-issues

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions