Skip to content

Commit 4948ed4

Browse files
committed
update documentation typo and align test
1 parent 9526faf commit 4948ed4

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

library/src/main/java/com/digicert/validation/exceptions/ValidationException.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public ValidationException(Set<DcvError> errors) {
4747
*
4848
* @param dcvErrors the set of DCV errors
4949
* @param cause the cause of the exception
50-
* @param dnssecDetails dnssecDetails the DNSSEC details associated with this exception
50+
* @param dnssecDetails the DNSSEC details associated with this exception
5151
*/
5252
public ValidationException(Set<DcvError> dcvErrors, Throwable cause, DnssecDetails dnssecDetails) {
5353
super(dcvErrors, cause, dnssecDetails);

library/src/main/java/com/digicert/validation/methods/dns/DnsValidator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@ public DomainValidationEvidence validate(DnsValidationRequest dnsValidationReque
139139
dnsValidationResponse.errors());
140140

141141
DnssecDetails dnssecDetails = null;
142-
if (dnsValidationResponse.errors().contains(DcvError.DNS_LOOKUP_DNSSEC_FAILURE)
143-
&& dnsValidationResponse.mpicDetails() != null) {
142+
if (dnsValidationResponse.mpicDetails() != null && dnsValidationResponse.mpicDetails().dnssecDetails() != null) {
144143
dnssecDetails = dnsValidationResponse.mpicDetails().dnssecDetails();
145144
}
146145
if (dnssecDetails != null) {

library/src/test/java/com/digicert/validation/methods/dns/DnsValidatorTest.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,23 +207,29 @@ void testDnsValidator_prepare_InvalidDnsPreparation(String domain, DnsType dnsTy
207207

208208
@Test
209209
void testDnsValidator_validate_dnssec_dnskey_missing() {
210-
MpicDetails getMpicDetails = new MpicDetails(true,
210+
DnssecDetails expectedDnssecDetails = new DnssecDetails(DnssecStatus.INSECURE, DnssecError.DNSKEY_MISSING, null, "no SEP matching the DS found");
211+
MpicDetails mpicDetails = new MpicDetails(true,
211212
"primary-agent",
212213
3,
213214
3,
214-
new DnssecDetails(DnssecStatus.INSECURE, DnssecError.DNSKEY_MISSING, null, "no SEP matching the DS found"),
215+
expectedDnssecDetails,
215216
Map.of("secondary-agent-id", true), null);
216-
DnsValidationResponse dnsValidationResponse = new DnsValidationResponse(false, getMpicDetails, domain, domain,
217+
DnsValidationResponse dnsValidationResponse = new DnsValidationResponse(false, mpicDetails, domain, domain,
217218
dnsType, randomValue, null, Set.of(DcvError.DNS_LOOKUP_DNSSEC_FAILURE));
218219

219220
when(dnsValidationHandler.validate(any(DnsValidationRequest.class))).thenReturn(dnsValidationResponse);
220221

221222
ValidationException exception = assertThrows(ValidationException.class, () -> dnsValidator.validate(dnsValidationRequest));
222223

223-
assertEquals(1, exception.getErrors().size(), "Expected exactly one error ");
224+
assertEquals(1, exception.getErrors().size(), "Expected exactly one error");
224225
assertTrue(exception.getErrors().contains(DcvError.DNS_LOOKUP_DNSSEC_FAILURE), "expected: " + DcvError.DNS_LOOKUP_DNSSEC_FAILURE + " but got: " + exception.getErrors());
226+
assertNotNull(exception.getDnssecDetails(), "DNSSEC details should be present in the exception");
227+
assertEquals(expectedDnssecDetails, exception.getDnssecDetails(), "DNSSEC details should match the response");
228+
assertEquals(DnssecStatus.INSECURE, exception.getDnssecDetails().dnssecStatus());
229+
assertEquals(DnssecError.DNSKEY_MISSING, exception.getDnssecDetails().dnssecError());
225230
}
226231

232+
227233
private static MpicDetails getMpicDetails() {
228234
return new MpicDetails(true,
229235
"primary-agent",

0 commit comments

Comments
 (0)