Changes as per comment

Author: Jignesh-dimagi

app/src/org/commcare/CommCareNoficationManager.java

@@ -40,7 +40,7 @@ public class CommCareNoficationManager {
     public static final String NOTIFICATION_CHANNEL_USER_SESSION_ID = "notification-channel-user-session";
     public static final String NOTIFICATION_CHANNEL_SERVER_COMMUNICATIONS_ID = "notification-channel-server-communications";
     public static final String OLD_NOTIFICATION_CHANNEL_PUSH_NOTIFICATIONS_ID = "notification-channel-push-notifications";
-    public static final String NEW_HIGH_PRIORITY_NOTIFICATION_CHANNEL_PUSH_NOTIFICATIONS_ID = "notification-channel-high-priority-push-notifications";
+    public static final String NOTIFICATION_CHANNEL_GENERAL_PUSH_NOTIFICATIONS_ID = "notification-channel-general-push-notifications";
     public static final String NOTIFICATION_CHANNEL_MESSAGING_ID = "notification-channel-messaging";
 
     /**
@@ -193,7 +193,7 @@ public void createNotificationChannels() {
                 NotificationManager.IMPORTANCE_LOW);
 
         deleteIfOldPushNotificationExists();
-        createNotificationChannel(NEW_HIGH_PRIORITY_NOTIFICATION_CHANNEL_PUSH_NOTIFICATIONS_ID,
+        createNotificationChannel(NOTIFICATION_CHANNEL_GENERAL_PUSH_NOTIFICATIONS_ID,
                 R.string.notification_channel_push_notfications_title,
                 R.string.notification_channel_push_notfications_description,
                 NotificationManager.IMPORTANCE_HIGH);

app/src/org/commcare/pn/workermanager/NotificationsSyncWorkerManager.kt

@@ -125,6 +125,9 @@ class NotificationsSyncWorkerManager(
 
     /**
      * This can receive the push notification data payload from FCM and notification API.
+     * @param context - android context
+     * @param showNotification - decide whether to show a notification or not after sync is successful.
+     * @param syncNotification - decide to pull / sync any pending notifications or not.
      */
     constructor(
         context: Context,
@@ -193,7 +196,7 @@ class NotificationsSyncWorkerManager(
     fun startSyncWorkers(notificationsPayload: ArrayList<Map<String, String>>?) {
         notificationsPayload?.let {
             for (notificationPayload in notificationsPayload) {
-                parseAndStartNotificationWorker(notificationPayload) //  syncNotification is false always as this method will check for sync
+                parseAndStartNotificationWorker(notificationPayload)
             }
         }
         syncNotificationIfRequired()

app/src/org/commcare/services/FCMMessageData.java

@@ -60,7 +60,7 @@ public FCMMessageData(Map<String, String> payloadData) {
         notificationText = payloadData.get(NOTIFICATION_BODY);
         action = payloadData.get(REDIRECT_ACTION);
         priority = NotificationCompat.PRIORITY_MAX;
-        notificationChannel = CommCareNoficationManager.NEW_HIGH_PRIORITY_NOTIFICATION_CHANNEL_PUSH_NOTIFICATIONS_ID;
+        notificationChannel = CommCareNoficationManager.NOTIFICATION_CHANNEL_GENERAL_PUSH_NOTIFICATIONS_ID;
         smallIcon = R.drawable.commcare_actionbar_logo;
     }