debain trixie / gcc 14 build erros

[geosone]

make[3]: Entering directory '/build/freenx-server-2.1.3~20250808153929.5+trixie/nxviewer-passwd/libvncauth' gcc -g -O2 -fno-strict-aliasing -I. -I../include -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -Wdate-time -D_FORTIFY_SOURCE=2 -c -o vncauth.o vncauth.c In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33, from /usr/include/stdio.h:28, from vncauth.c:24: /usr/include/features.h:199:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] 199 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" | ^~~~~~~ vncauth.c: In function 'vncEncryptAndStorePasswd': vncauth.c:60:13: error: implicit declaration of function 'vncEncryptAndStorePasswd2'; did you mean 'vncEncryptAndStorePasswd'? [-Wimplicit-function-declaration] 60 | return (vncEncryptAndStorePasswd2(passwd, NULL, fname) == 0); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | vncEncryptAndStorePasswd vncauth.c: In function 'vncDecryptPasswdFromFile': vncauth.c:131:13: error: implicit declaration of function 'vncDecryptPasswdFromFile2'; did you mean 'vncDecryptPasswdFromFile'? [-Wimplicit-function-declaration] 131 | if (vncDecryptPasswdFromFile2(fname, passwd, NULL) == 0) { | ^~~~~~~~~~~~~~~~~~~~~~~~~ | vncDecryptPasswdFromFile vncauth.c: In function 'vncRandomBytes': vncauth.c:211:28: error: implicit declaration of function 'time' [-Wimplicit-function-declaration] 211 | seed = (unsigned int)time(0) ^ (unsigned int)getpid(); | ^~~~ vncauth.c:32:1: note: 'time' is defined in header '<time.h>'; this is probably fixable by adding '#include <time.h>' 31 | #include <d3des.h> +++ |+#include <time.h> 32 | make[3]: *** [<builtin>: vncauth.o] Error 1 make[3]: Leaving directory '/build/freenx-server-2.1.3~20250808153929.5+trixie/nxviewer-passwd/libvncauth' make[2]: *** [Makefile:1057: all] Error 2 make[2]: Leaving directory '/build/freenx-server-2.1.3~20250808153929.5+trixie/nxviewer-passwd' make[1]: *** [Makefile:26: all] Error 1 make[1]: Leaving directory '/build/freenx-server-2.1.3~20250808153929.5+trixie' dh_auto_build: error: make -j1 returned exit code 2 make: *** [debian/rules:6: binary] Error 255

the buidl fails under gcc 14

[dimbor-ru]

vncauth.c ... this is probably fixable by adding '#include <time.h>'

Does this solve the problem?

[geosone]

no its not

gcc -g -O2 -fno-strict-aliasing -I. -I../include -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DFUNCPROTO=15 -DNARROWPROTO -Wdate-time -D_FORTIFY_SOURCE=2 -c -o vncauth.o vncauth.c
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
from /usr/include/stdio.h:28,
from vncauth.c:24:
/usr/include/features.h:199:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
199 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
| ^~~~~~~
vncauth.c: In function ‘vncEncryptAndStorePasswd’:
vncauth.c:61:13: error: implicit declaration of function ‘vncEncryptAndStorePasswd2’; did you mean ‘vncEncryptAndStorePasswd’? [-Wimplicit-function-declaration]
61 | return (vncEncryptAndStorePasswd2(passwd, NULL, fname) == 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| vncEncryptAndStorePasswd
vncauth.c: In function ‘vncDecryptPasswdFromFile’:
vncauth.c:132:13: error: implicit declaration of function ‘vncDecryptPasswdFromFile2’; did you mean ‘vncDecryptPasswdFromFile’? [-Wimplicit-function-declaration]
132 | if (vncDecryptPasswdFromFile2(fname, passwd, NULL) == 0) {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| vncDecryptPasswdFromFile
make[3]: *** [: vncauth.o] Fehler 1
make[3]: Verzeichnis „/root/freenx-server/nxviewer-passwd/libvncauth“ wird verlassen
make[2]: *** [Makefile:1057: all] Fehler 2
make[2]: Verzeichnis „/root/freenx-server/nxviewer-passwd“ wird verlassen
make[1]: *** [Makefile:26: all] Fehler 1
make[1]: Verzeichnis „/root/freenx-server“ wird verlassen

[dimbor-ru]

Ups! All of my systems are too old and I'm not familiar with gcc 14. I suppose he needs some defines to reduce his severity.
libvncauth code is part of tightvnc project. You can look for how the problem was solved when building it under new gcc.
Another way is to correct the errors. In this case, you need to write function prototypes (vnc*2) at the top of vncauth.c file.

[geosone]

on debain trixie the rules file for tightvnc has this added

Make sure the decades-old source code gets compiled by allowing implicit

function declarations and, for gcc-14 and above, by downgrading the

diagnostics applied by the compiler. See

https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Warning-Options.html

for further details.

export DEB_CFLAGS_MAINT_STRIP=-Werror=implicit-function-declaration
cc_major := $(shell $(CC) --version | head -n1 | cut -d' ' -f4 | cut -d. -f1)
cc_major_ge_14 := $(shell [ $(cc_major) -ge 14 ] && echo 'true')
export DEB_CFLAGS_MAINT_APPEND=$(if $(cc_major_ge_14),-fpermissive)

where to add it ?

[dimbor-ru]

Insert this to debian/rules, as I understand it

[geosone]

tried it did not work

tightvnc uses automake whre teh MAINT is present.

here we only have makefiel

[geosone]

found a sollution

https://gitea.disconnected-by-peer.at/NX/freenx-server/commit/4a75ee5050ba6efd854749eabf8e7bafcf151332

[dimbor-ru]

Congratulations! Please make a pull request here. Or I can add your patch myself, but later.

[geosone]

dont know if i schoudl put it into debian/patches as i think it would make sense to do it genrally

https://gitea.disconnected-by-peer.at/NX/freenx-server/commit/2bc1e7889e2af8823069ba4267c97a198030f8fb

[dimbor-ru]

The user (by nxnode) wrote there to speed up the launch of sessions. Of course, this is not a very correct behavior, but it was easier. It is connected with the fact that the server searches for the client printer driver in cups only at the first launch and copies it. At subsequent launches, ppd is taken from this directory. The driver should be stored in the user's directory. But I have many users with the same printers, and I'm lazy ;)

[geosone]

as the rights are set for debain in th post install script this chown in the build fails in the debian 13 default hardening build.

[dimbor-ru]

Ok, give me a week or two. I'll try to fix it.

[geosone]

https://debdev.disconnected-by-peer.at/pool/main/f/freenx-server/ yesss

[geosone]

not related but i also repacked the nxcleint 3.5.0 with the glibc fix

https://gitea.disconnected-by-peer.at/NX/nxclient
https://debdev.disconnected-by-peer.at/pool/main/n/nxclient/

will apper int he new NX repo tomorrow

https://ftp.disconnected-by-peer.at/Repositories/go-NX/

have a nice weekend

[dimbor-ru]

1. 7079c23
2. a21f831